From: Mark Brown <broonie@kernel.org>
To: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Yixun Lan <dlan@kernel.org>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
jinmei.wei@spacemit.com
Subject: Re: [PATCH 1/3] ASoC: soc-dai: add shared BCLK clock for cross-DAI rate constraints
Date: Thu, 30 Apr 2026 21:01:45 +0900 [thread overview]
Message-ID: <afNEqXIKRgzRJt7W@sirena.co.uk> (raw)
In-Reply-To: <20260430-i2s-same-blk-v1-1-3a1f04eb6159@linux.spacemit.com>
[-- Attachment #1: Type: text/plain, Size: 442 bytes --]
On Thu, Apr 30, 2026 at 03:46:01PM +0800, Troy Mitchell wrote:
> @@ -116,10 +116,27 @@ int snd_soc_dai_set_bclk_ratio(struct snd_soc_dai *dai, unsigned int ratio)
> dai->driver->ops->set_bclk_ratio)
> ret = dai->driver->ops->set_bclk_ratio(dai, ratio);
>
> + dai->bclk_ratio = ratio;
> +
> return soc_dai_ret(dai, ret);
> }
This needs an error check, if the op fails we'll write the error code as
the BCLK ratio.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-04-30 12:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 7:46 [PATCH 0/3] ASoC: add shared BCLK rate constraint for cross-DAI coordination Troy Mitchell
2026-04-30 7:46 ` [PATCH 1/3] ASoC: soc-dai: add shared BCLK clock for cross-DAI rate constraints Troy Mitchell
2026-04-30 12:01 ` Mark Brown [this message]
2026-04-30 7:46 ` [PATCH 2/3] ASoC: soc-pcm: constrain hw_params when DAIs share the same BCLK Troy Mitchell
2026-04-30 12:05 ` Mark Brown
2026-04-30 7:46 ` [PATCH 3/3] ASoC: spacemit: declare shared BCLK for cross-DAI rate constraint Troy Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afNEqXIKRgzRJt7W@sirena.co.uk \
--to=broonie@kernel.org \
--cc=dlan@kernel.org \
--cc=jinmei.wei@spacemit.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=spacemit@lists.linux.dev \
--cc=tiwai@suse.com \
--cc=troy.mitchell@linux.spacemit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox