From: Mike Rapoport <rppt@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <roman.gushchin@linux.dev>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
David Hildenbrand <david@kernel.org>, Jan Kara <jack@suse.cz>,
Peter Xu <peterx@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 0/2] userfaultfd: merge fs/userfaultfd.c into mm/userfaultfd.c
Date: Fri, 1 May 2026 16:57:08 +0200 [thread overview]
Message-ID: <afS_RKHNBuiDoR11@kernel.org> (raw)
In-Reply-To: <20260430090110.f3ed78910ea7cface7d73199@linux-foundation.org>
On Thu, Apr 30, 2026 at 09:01:10AM -0700, Andrew Morton wrote:
> On Thu, 30 Apr 2026 14:35:10 +0300 Mike Rapoport <rppt@kernel.org> wrote:
>
> > These patches merge fs/userfaultfd.c into mm/userfaultfd.c and make
> > functions used only inside mm/userfaultfd.c static.
>
> It's kinda scary how often Sashiko finds existing issues just because
> we made it look.
>
> https://sashiko.dev/#/patchset/20260430113512.115938-1-rppt@kernel.org
>
> Do either of these look legit? If so, it would be better to fix them
> before doing the code movement, for backporting ease.
One is real, another one is not.
> Another issue in the moved code: the ctx variable is annotated with
> __free(kfree) but allocated using kmem_cache_alloc() from the custom
> userfaultfd_ctx_cachep cache.
@Roman, can you please explain to sashiko that kfree() is fine with
kmem_cache_alloc()?
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2026-05-01 14:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 11:35 [PATCH 0/2] userfaultfd: merge fs/userfaultfd.c into mm/userfaultfd.c Mike Rapoport
2026-04-30 11:35 ` [PATCH 1/2] " Mike Rapoport
2026-04-30 11:35 ` [PATCH 2/2] userfaultfd: make functions that are not used outside uffd static Mike Rapoport
2026-04-30 11:38 ` [PATCH 0/2] userfaultfd: merge fs/userfaultfd.c into mm/userfaultfd.c David Hildenbrand (Arm)
2026-04-30 14:23 ` David Hildenbrand (Arm)
2026-04-30 14:55 ` Mike Rapoport
2026-04-30 14:56 ` Mike Rapoport
2026-05-01 18:33 ` David Hildenbrand (Arm)
2026-05-02 4:38 ` Mike Rapoport
2026-05-02 6:37 ` David Hildenbrand (Arm)
2026-04-30 16:01 ` Andrew Morton
2026-05-01 14:57 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afS_RKHNBuiDoR11@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=david@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=roman.gushchin@linux.dev \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox