* Re: [PATCH] virtio: Directly use ida_alloc_range()/ida_free()
@ 2022-06-09 0:42 tomorrow Wang (王德明)
2022-06-09 4:59 ` Christophe JAILLET
0 siblings, 1 reply; 5+ messages in thread
From: tomorrow Wang (王德明) @ 2022-06-09 0:42 UTC (permalink / raw)
To: christophe.jaillet@wanadoo.fr, mst@redhat.com,
jasowang@redhat.com
Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 1608 bytes --]
Hi,
> Hi,
>
> Le 08/06/2022 à 08:08, Deming Wang a écrit :
> > Use ida_alloc_range()/ida_free() instead of deprecated
> > ida_simple_get()/ida_simple_remove() .
> >
> > Signed-off-by: Deming Wang <wangdeming@inspur.com>
> > ---
> > drivers/vhost/vdpa.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index
> > 935a1d0ddb97..384049cfca8d 100644
> > --- a/drivers/vhost/vdpa.c
> > +++ b/drivers/vhost/vdpa.c
> > @@ -1293,7 +1293,7 @@ static void vhost_vdpa_release_dev(struct device
> *device)
> > struct vhost_vdpa *v =
> > container_of(device, struct vhost_vdpa, dev);
> >
> > - ida_simple_remove(&vhost_vdpa_ida, v->minor);
> > + ida_free(&vhost_vdpa_ida, v->minor);
> > kfree(v->vqs);
> > kfree(v);
> > }
> > @@ -1316,8 +1316,7 @@ static int vhost_vdpa_probe(struct vdpa_device
> *vdpa)
> > if (!v)
> > return -ENOMEM;
> >
> > - minor = ida_simple_get(&vhost_vdpa_ida, 0,
> > - VHOST_VDPA_DEV_MAX, GFP_KERNEL);
> > + minor = ida_alloc_range(&vhost_vdpa_ida, 0, VHOST_VDPA_DEV_MAX -
> 1,
> > +GFP_KERNEL);
>
> ida_alloc_max() would be better here. It is less verbose.
>
> An explanation in the commit log of why the -1 is needed would also help
> reviewer/maintainer, IMHO.
>
> It IS correct, but it is not that obvious without looking at
> ida_simple_get() and ida_alloc_range().
>
> CJ
>
>
> > if (minor < 0) {
> > kfree(v);
> > return minor;
can I mention one patch about repair ida_free for this.
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 3780 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] virtio: Directly use ida_alloc_range()/ida_free()
2022-06-09 0:42 [PATCH] virtio: Directly use ida_alloc_range()/ida_free() tomorrow Wang (王德明)
@ 2022-06-09 4:59 ` Christophe JAILLET
0 siblings, 0 replies; 5+ messages in thread
From: Christophe JAILLET @ 2022-06-09 4:59 UTC (permalink / raw)
To: tomorrow Wang (王德明), mst@redhat.com,
jasowang@redhat.com
Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Le 09/06/2022 à 02:42, tomorrow Wang (王德明) a écrit :
>>
>> An explanation in the commit log of why the -1 is needed would also help
>> reviewer/maintainer, IMHO.
>>
>> It IS correct, but it is not that obvious without looking at
>> ida_simple_get() and ida_alloc_range().
>>
>
> can I mention one patch about repair ida_free for this.
>
>
If you manage to find another patch and provide a lore.kernel.org link
to it, I think it should be okay.
However, after a *quick* look in some mailing list, I've not found yet a
description for that.
CJ
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] virtio: Directly use ida_alloc_range()/ida_free()
@ 2022-06-08 6:14 Deming Wang
0 siblings, 0 replies; 5+ messages in thread
From: Deming Wang @ 2022-06-08 6:14 UTC (permalink / raw)
To: mst, jasowang; +Cc: kvm, virtualization, netdev, linux-kernel, Deming Wang
Use ida_alloc_range()/ida_free() instead of deprecated
ida_simple_get()/ida_simple_remove() .
Signed-off-by: Deming Wang <wangdeming@inspur.com>
---
drivers/vhost/vdpa.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
index 935a1d0ddb97..384049cfca8d 100644
--- a/drivers/vhost/vdpa.c
+++ b/drivers/vhost/vdpa.c
@@ -1293,7 +1293,7 @@ static void vhost_vdpa_release_dev(struct device *device)
struct vhost_vdpa *v =
container_of(device, struct vhost_vdpa, dev);
- ida_simple_remove(&vhost_vdpa_ida, v->minor);
+ ida_free(&vhost_vdpa_ida, v->minor);
kfree(v->vqs);
kfree(v);
}
@@ -1316,8 +1316,7 @@ static int vhost_vdpa_probe(struct vdpa_device *vdpa)
if (!v)
return -ENOMEM;
- minor = ida_simple_get(&vhost_vdpa_ida, 0,
- VHOST_VDPA_DEV_MAX, GFP_KERNEL);
+ minor = ida_alloc_range(&vhost_vdpa_ida, 0, VHOST_VDPA_DEV_MAX - 1, GFP_KERNEL);
if (minor < 0) {
kfree(v);
return minor;
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] virtio: Directly use ida_alloc_range()/ida_free()
@ 2022-06-08 6:08 Deming Wang
2022-06-08 19:06 ` Christophe JAILLET
0 siblings, 1 reply; 5+ messages in thread
From: Deming Wang @ 2022-06-08 6:08 UTC (permalink / raw)
To: mst, jasowang; +Cc: kvm, virtualization, netdev, linux-kernel, Deming Wang
Use ida_alloc_range()/ida_free() instead of deprecated
ida_simple_get()/ida_simple_remove() .
Signed-off-by: Deming Wang <wangdeming@inspur.com>
---
drivers/vhost/vdpa.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
index 935a1d0ddb97..384049cfca8d 100644
--- a/drivers/vhost/vdpa.c
+++ b/drivers/vhost/vdpa.c
@@ -1293,7 +1293,7 @@ static void vhost_vdpa_release_dev(struct device *device)
struct vhost_vdpa *v =
container_of(device, struct vhost_vdpa, dev);
- ida_simple_remove(&vhost_vdpa_ida, v->minor);
+ ida_free(&vhost_vdpa_ida, v->minor);
kfree(v->vqs);
kfree(v);
}
@@ -1316,8 +1316,7 @@ static int vhost_vdpa_probe(struct vdpa_device *vdpa)
if (!v)
return -ENOMEM;
- minor = ida_simple_get(&vhost_vdpa_ida, 0,
- VHOST_VDPA_DEV_MAX, GFP_KERNEL);
+ minor = ida_alloc_range(&vhost_vdpa_ida, 0, VHOST_VDPA_DEV_MAX - 1, GFP_KERNEL);
if (minor < 0) {
kfree(v);
return minor;
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] virtio: Directly use ida_alloc_range()/ida_free()
2022-06-08 6:08 Deming Wang
@ 2022-06-08 19:06 ` Christophe JAILLET
0 siblings, 0 replies; 5+ messages in thread
From: Christophe JAILLET @ 2022-06-08 19:06 UTC (permalink / raw)
To: Deming Wang, mst, jasowang; +Cc: kvm, virtualization, netdev, linux-kernel
Hi,
Le 08/06/2022 à 08:08, Deming Wang a écrit :
> Use ida_alloc_range()/ida_free() instead of deprecated
> ida_simple_get()/ida_simple_remove() .
>
> Signed-off-by: Deming Wang <wangdeming@inspur.com>
> ---
> drivers/vhost/vdpa.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
> index 935a1d0ddb97..384049cfca8d 100644
> --- a/drivers/vhost/vdpa.c
> +++ b/drivers/vhost/vdpa.c
> @@ -1293,7 +1293,7 @@ static void vhost_vdpa_release_dev(struct device *device)
> struct vhost_vdpa *v =
> container_of(device, struct vhost_vdpa, dev);
>
> - ida_simple_remove(&vhost_vdpa_ida, v->minor);
> + ida_free(&vhost_vdpa_ida, v->minor);
> kfree(v->vqs);
> kfree(v);
> }
> @@ -1316,8 +1316,7 @@ static int vhost_vdpa_probe(struct vdpa_device *vdpa)
> if (!v)
> return -ENOMEM;
>
> - minor = ida_simple_get(&vhost_vdpa_ida, 0,
> - VHOST_VDPA_DEV_MAX, GFP_KERNEL);
> + minor = ida_alloc_range(&vhost_vdpa_ida, 0, VHOST_VDPA_DEV_MAX - 1, GFP_KERNEL);
ida_alloc_max() would be better here. It is less verbose.
An explanation in the commit log of why the -1 is needed would also help
reviewer/maintainer, IMHO.
It IS correct, but it is not that obvious without looking at
ida_simple_get() and ida_alloc_range().
CJ
> if (minor < 0) {
> kfree(v);
> return minor;
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-09 4:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-09 0:42 [PATCH] virtio: Directly use ida_alloc_range()/ida_free() tomorrow Wang (王德明)
2022-06-09 4:59 ` Christophe JAILLET
-- strict thread matches above, loose matches on Subject: below --
2022-06-08 6:14 Deming Wang
2022-06-08 6:08 Deming Wang
2022-06-08 19:06 ` Christophe JAILLET
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox