public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: rtl8723bs: remove unnecessary blank lines
@ 2026-05-01 16:38 Stepan Ionichev
  2026-05-02  8:49 ` [PATCH v2] staging: rtl8723bs: remove unnecessary blank lines in rtw_ioctl_set.c Stepan Ionichev
  0 siblings, 1 reply; 4+ messages in thread
From: Stepan Ionichev @ 2026-05-01 16:38 UTC (permalink / raw)
  To: gregkh; +Cc: linux-staging, linux-kernel, Stepan Ionichev

Drop blank lines flagged by checkpatch.pl in rtw_ioctl_set.c:

  CHECK: Blank lines aren't necessary before a close brace '}'
  CHECK: Please don't use multiple blank lines
  CHECK: Blank lines aren't necessary after an open brace '{'

No functional change.

Signed-off-by: Stepan Ionichev <sozdayvek@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
index c70541f95..8edc62752 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
@@ -120,9 +120,7 @@ u8 rtw_do_join(struct adapter *padapter)
 					pmlmepriv->to_join = false;
 				}
 			}
-
 		}
-
 	}
 
 exit:
@@ -340,7 +338,6 @@ u8 rtw_set_802_11_infrastructure_mode(struct adapter *padapter,
 	return true;
 }
 
-
 u8 rtw_set_802_11_disassociate(struct adapter *padapter)
 {
 	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
@@ -417,7 +414,6 @@ u8 rtw_set_802_11_authentication_mode(struct adapter *padapter, enum ndis_802_11
 
 u8 rtw_set_802_11_add_wep(struct adapter *padapter, struct ndis_802_11_wep *wep)
 {
-
 	signed int		keyid, res;
 	struct security_priv *psecuritypriv = &(padapter->securitypriv);
 	u8 ret = _SUCCESS;
-- 
2.33.0.windows.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2] staging: rtl8723bs: remove unnecessary blank lines in rtw_ioctl_set.c
  2026-05-01 16:38 [PATCH] staging: rtl8723bs: remove unnecessary blank lines Stepan Ionichev
@ 2026-05-02  8:49 ` Stepan Ionichev
  2026-05-04 12:44   ` Nikolay Kulikov
  2026-05-04 13:03   ` Luka Gejak
  0 siblings, 2 replies; 4+ messages in thread
From: Stepan Ionichev @ 2026-05-02  8:49 UTC (permalink / raw)
  To: gregkh; +Cc: linux-staging, linux-kernel, luka.gejak, Stepan Ionichev

Drop blank lines flagged by checkpatch.pl in rtw_ioctl_set.c:

  CHECK: Blank lines aren't necessary before a close brace '}'
  CHECK: Blank lines aren't necessary after an open brace '{'

No functional change.

Signed-off-by: Stepan Ionichev <sozdayvek@gmail.com>
---
v2:
- Rebased onto staging-next.
- Dropped the hunk between rtw_set_802_11_infrastructure_mode() and
  rtw_set_802_11_disassociate(): already addressed by commit 7dbc9fd71438
  ("staging: rtl8723bs: remove multiple blank lines in core/").
- Narrowed subject to mention rtw_ioctl_set.c, since the wider scope is
  no longer needed.

 drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
index 69cbf89f0..3cc2a7c9d 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
@@ -120,9 +120,7 @@ u8 rtw_do_join(struct adapter *padapter)
 					pmlmepriv->to_join = false;
 				}
 			}
-
 		}
-
 	}
 
 exit:
@@ -416,7 +414,6 @@ u8 rtw_set_802_11_authentication_mode(struct adapter *padapter, enum ndis_802_11
 
 u8 rtw_set_802_11_add_wep(struct adapter *padapter, struct ndis_802_11_wep *wep)
 {
-
 	signed int		keyid, res;
 	struct security_priv *psecuritypriv = &(padapter->securitypriv);
 	u8 ret = _SUCCESS;
-- 
2.33.0.windows.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] staging: rtl8723bs: remove unnecessary blank lines in rtw_ioctl_set.c
  2026-05-02  8:49 ` [PATCH v2] staging: rtl8723bs: remove unnecessary blank lines in rtw_ioctl_set.c Stepan Ionichev
@ 2026-05-04 12:44   ` Nikolay Kulikov
  2026-05-04 13:03   ` Luka Gejak
  1 sibling, 0 replies; 4+ messages in thread
From: Nikolay Kulikov @ 2026-05-04 12:44 UTC (permalink / raw)
  To: Stepan Ionichev; +Cc: gregkh, linux-staging, linux-kernel, luka.gejak

On Sat, May 02, 2026 at 01:49:30PM +0500, Stepan Ionichev wrote:
> Drop blank lines flagged by checkpatch.pl in rtw_ioctl_set.c:
> 
>   CHECK: Blank lines aren't necessary before a close brace '}'
>   CHECK: Blank lines aren't necessary after an open brace '{'
> 
> No functional change.
> 
> Signed-off-by: Stepan Ionichev <sozdayvek@gmail.com>

Looks good to me.

Reviewed-by: Nikolay Kulikov <nikolayof23@gmail.com>


Thanks,
Nikolay

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] staging: rtl8723bs: remove unnecessary blank lines in rtw_ioctl_set.c
  2026-05-02  8:49 ` [PATCH v2] staging: rtl8723bs: remove unnecessary blank lines in rtw_ioctl_set.c Stepan Ionichev
  2026-05-04 12:44   ` Nikolay Kulikov
@ 2026-05-04 13:03   ` Luka Gejak
  1 sibling, 0 replies; 4+ messages in thread
From: Luka Gejak @ 2026-05-04 13:03 UTC (permalink / raw)
  To: Stepan Ionichev, gregkh; +Cc: linux-staging, linux-kernel, luka.gejak

On May 2, 2026 10:49:30 AM GMT+02:00, Stepan Ionichev <sozdayvek@gmail.com> wrote:
>Drop blank lines flagged by checkpatch.pl in rtw_ioctl_set.c:
>
>  CHECK: Blank lines aren't necessary before a close brace '}'
>  CHECK: Blank lines aren't necessary after an open brace '{'
>
>No functional change.
>
>Signed-off-by: Stepan Ionichev <sozdayvek@gmail.com>
>---
>v2:
>- Rebased onto staging-next.
>- Dropped the hunk between rtw_set_802_11_infrastructure_mode() and
>  rtw_set_802_11_disassociate(): already addressed by commit 7dbc9fd71438
>  ("staging: rtl8723bs: remove multiple blank lines in core/").
>- Narrowed subject to mention rtw_ioctl_set.c, since the wider scope is
>  no longer needed.
>
> drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 3 ---
> 1 file changed, 3 deletions(-)
>

LGTM,

Reviewed-by: Luka Gejak <luka.gejak@linux.dev>

Best regards,
Luka Gejak


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-05-04 13:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-01 16:38 [PATCH] staging: rtl8723bs: remove unnecessary blank lines Stepan Ionichev
2026-05-02  8:49 ` [PATCH v2] staging: rtl8723bs: remove unnecessary blank lines in rtw_ioctl_set.c Stepan Ionichev
2026-05-04 12:44   ` Nikolay Kulikov
2026-05-04 13:03   ` Luka Gejak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox