From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] vsprintf: Only export no_hash_pointers to test module
Date: Mon, 4 May 2026 17:11:44 +0300 [thread overview]
Message-ID: <afipIJgyBFLuCL1H@ashevche-desk.local> (raw)
In-Reply-To: <20260504135014-f477a0fe-1af6-4a85-9259-3056a13c0d1f@linutronix.de>
On Mon, May 04, 2026 at 01:53:47PM +0200, Thomas Weißschuh wrote:
> On Mon, May 04, 2026 at 01:57:31PM +0300, Andy Shevchenko wrote:
> > On Mon, May 04, 2026 at 12:43:40PM +0200, Thomas Weißschuh wrote:
...
> > > -EXPORT_SYMBOL_GPL(no_hash_pointers);
> >
> > > +#if IS_MODULE(CONFIG_PRINTF_KUNIT_TEST)
> > > +EXPORT_SYMBOL_FOR_MODULES(no_hash_pointers, "printf_kunit");
> > > +#endif
> >
> > But do we need that ugly ifdeffery? the infrastructure should handle that.
>
> Where does the generic infrastructure take the kconfig option into account?
Nowhere, but my point that it's taken care of at run-time.
> > (Also, if I build a module separately after the kernel, it won't work.)
>
> Only if it was not enabled when the kernel was built.
>
> But if people are unhappy with the ifdeffery, I'm fine with dropping it.
> It is not a hard requirement at all.
I think it's unnecessary to have. But I'm not a maintainer of this code.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-04 14:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 10:43 [PATCH v2 0/2] vsprintf: Add test for restricted kernel pointers Thomas Weißschuh
2026-05-04 10:43 ` [PATCH v2 1/2] vsprintf: Only export no_hash_pointers to test module Thomas Weißschuh
2026-05-04 10:57 ` Andy Shevchenko
2026-05-04 11:53 ` Thomas Weißschuh
2026-05-04 14:11 ` Andy Shevchenko [this message]
2026-05-04 10:43 ` [PATCH v2 2/2] vsprintf: Add test for restricted kernel pointers Thomas Weißschuh
2026-05-04 10:58 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afipIJgyBFLuCL1H@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox