From: Hamza Mahfooz <someguy@effective-light.com>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: dri-devel@lists.freedesktop.org,
"Harry Wentland" <harry.wentland@amd.com>,
"Leo Li" <sunpeng.li@amd.com>,
"Rodrigo Siqueira" <siqueira@igalia.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Alex Hung" <alex.hung@amd.com>, "Ray Wu" <ray.wu@amd.com>,
"Wayne Lin" <Wayne.Lin@amd.com>,
"Aurabindo Pillai" <aurabindo.pillai@amd.com>,
"Timur Kristóf" <timur.kristof@gmail.com>,
"Mario Limonciello (AMD)" <superm1@kernel.org>,
"Ivan Lipski" <ivan.lipski@amd.com>,
"Chenyu Chen" <chen-yu.chen@amd.com>,
"Matthew Schwartz" <matthew.schwartz@linux.dev>,
"Yussuf Khalil" <dev@pp3345.net>,
"Tom Chung" <chiahsuan.chung@amd.com>,
"Roman Li" <Roman.Li@amd.com>,
"Colin Ian King" <colin.i.king@gmail.com>,
"Charlene Liu" <charlene.liu@amd.com>,
"Kees Cook" <kees@kernel.org>,
amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/2] drm/atomic: attempt full modeset on page flip timeout
Date: Tue, 5 May 2026 07:41:03 -0400 [thread overview]
Message-ID: <afnXTwKBfjBYdwgL@hal-station.localdomain> (raw)
In-Reply-To: <5dd93e29-a076-491b-9861-e08a0204c77d@amd.com>
On Mon, May 04, 2026 at 04:50:21PM -0500, Mario Limonciello wrote:
> Do you actually need to set all 3 of these to true?
>
> I would think you only need:
>
> crtc_state->mode_changed = true;
>
According to my testing `mode_changed` on it's own is sufficient for
amdgpu and the documentation [1] seems to suggest that it should be fine
more broadly. Though, it doesn't seem harmful to set all of them just
for safe measure.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/drm/drm_crtc.h?h=v7.1-rc2#n118
next prev parent reply other threads:[~2026-05-05 11:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 20:35 [PATCH v5 1/2] drm/atomic: attempt full modeset on page flip timeout Hamza Mahfooz
2026-05-01 20:35 ` [PATCH v5 2/2] drm/amd/display: add DMU timeout recovery support Hamza Mahfooz
2026-05-04 21:51 ` Mario Limonciello
2026-05-05 16:02 ` Leo Li
2026-05-05 16:36 ` Leo Li
2026-05-05 16:41 ` Leo Li
2026-05-04 21:50 ` [PATCH v5 1/2] drm/atomic: attempt full modeset on page flip timeout Mario Limonciello
2026-05-05 11:41 ` Hamza Mahfooz [this message]
2026-05-05 15:32 ` Mario Limonciello
2026-05-05 18:12 ` Hamza Mahfooz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afnXTwKBfjBYdwgL@hal-station.localdomain \
--to=someguy@effective-light.com \
--cc=Roman.Li@amd.com \
--cc=Wayne.Lin@amd.com \
--cc=airlied@gmail.com \
--cc=alex.hung@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aurabindo.pillai@amd.com \
--cc=charlene.liu@amd.com \
--cc=chen-yu.chen@amd.com \
--cc=chiahsuan.chung@amd.com \
--cc=christian.koenig@amd.com \
--cc=colin.i.king@gmail.com \
--cc=dev@pp3345.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=ivan.lipski@amd.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mario.limonciello@amd.com \
--cc=matthew.schwartz@linux.dev \
--cc=mripard@kernel.org \
--cc=ray.wu@amd.com \
--cc=simona@ffwll.ch \
--cc=siqueira@igalia.com \
--cc=sunpeng.li@amd.com \
--cc=superm1@kernel.org \
--cc=timur.kristof@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox