From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 06/18] iio: magnetometer: ak8975: pass conversion timeouts as arguments
Date: Wed, 6 May 2026 10:20:44 +0300 [thread overview]
Message-ID: <afrrzM67n7NQWdE3@ashevche-desk.local> (raw)
In-Reply-To: <CALoEA-z+K8FzgwbYfi_aJ3oL6qi2TyXFDYKpmn1Mmjw8XApvNA@mail.gmail.com>
On Wed, May 06, 2026 at 09:02:15AM +0200, Joshua Crofts wrote:
> On Wed, 6 May 2026 at 08:34, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Tue, May 05, 2026 at 01:46:02PM +0200, Joshua Crofts via B4 Relay wrote:
...
> > > static int ak8975_start_read_axis(struct ak8975_data *data,
> > > const struct i2c_client *client)
> > > {
> > > - /* Set up the device for taking a sample. */
> > > - int ret = ak8975_set_mode(data, MODE_ONCE);
> > > + int ret;
> > >
> > > + /* Set up the device for taking a sample. */
> > > + ret = ak8975_set_mode(data, MODE_ONCE);
> >
> > But this piece does not belong to the main scope of the patch.
>
> Fair, probably a badly resolved merge conflict.
Hmm... Usually what we use is interactive rebase. Very powerful tool!
`git rebase --rebase-merges --interactive $SHA`
where $SHA is the same one that you used as --base for the series.
In conjunction with
`git reset HEAD~1; git commit -s --interactive -c ORIG_HEAD`
technique, you can easily move parts between patches.
(There are even more advanced techniques, but I'm an old-school guy.)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-06 7:20 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 11:45 [PATCH v5 00/18] iio: magnetometer: ak8975: modernize and cleanup driver Joshua Crofts via B4 Relay
2026-05-05 11:45 ` [PATCH v5 01/18] iio: magnetometer: ak8975: sort headers alphabetically Joshua Crofts via B4 Relay
2026-05-05 23:46 ` Maxwell Doose
2026-05-06 16:36 ` Jonathan Cameron
2026-05-05 11:45 ` [PATCH v5 02/18] iio: magnetometer: ak8975: update headers per IWYU principle Joshua Crofts via B4 Relay
2026-05-06 0:38 ` Maxwell Doose
2026-05-06 16:37 ` Jonathan Cameron
2026-05-05 11:45 ` [PATCH v5 03/18] iio: magnetometer: ak8975: replace usleep_range() with fsleep() Joshua Crofts via B4 Relay
2026-05-05 20:30 ` Maxwell Doose
2026-05-05 21:26 ` Joshua Crofts
2026-05-05 21:42 ` Maxwell Doose
2026-05-05 21:59 ` Joshua Crofts
2026-05-05 22:12 ` Maxwell Doose
2026-05-06 6:19 ` Andy Shevchenko
2026-05-06 6:35 ` Maxwell Doose
2026-05-06 16:39 ` Jonathan Cameron
2026-05-05 11:46 ` [PATCH v5 04/18] iio: magnetometer: ak8975: change 'u8*' to 'u8 *' in cast Joshua Crofts via B4 Relay
2026-05-06 0:47 ` Maxwell Doose
2026-05-06 6:30 ` Andy Shevchenko
2026-05-06 16:40 ` Jonathan Cameron
2026-05-05 11:46 ` [PATCH v5 05/18] iio: magnetometer: ak8975: fix wrong errno on return Joshua Crofts via B4 Relay
2026-05-06 16:41 ` Jonathan Cameron
2026-05-05 11:46 ` [PATCH v5 06/18] iio: magnetometer: ak8975: pass conversion timeouts as arguments Joshua Crofts via B4 Relay
2026-05-06 6:34 ` Andy Shevchenko
2026-05-06 7:02 ` Joshua Crofts
2026-05-06 7:20 ` Andy Shevchenko [this message]
2026-05-06 7:28 ` Joshua Crofts
2026-05-06 7:32 ` Andy Shevchenko
2026-05-06 16:51 ` Jonathan Cameron
2026-05-05 11:46 ` [PATCH v5 07/18] iio: magnetometer: ak8975: modernize polling loops with iopoll() macros Joshua Crofts via B4 Relay
2026-05-06 6:53 ` Andy Shevchenko
2026-05-06 7:01 ` Joshua Crofts
2026-05-06 10:50 ` Joshua Crofts
2026-05-06 13:08 ` Andy Shevchenko
2026-05-06 16:52 ` Jonathan Cameron
2026-05-05 11:46 ` [PATCH v5 08/18] iio: magnetometer: ak8975: check if gpiod read was successful Joshua Crofts via B4 Relay
2026-05-06 1:09 ` Maxwell Doose
2026-05-06 1:42 ` Maxwell Doose
2026-05-06 7:11 ` Andy Shevchenko
2026-05-06 7:13 ` Maxwell Doose
2026-05-06 7:16 ` Andy Shevchenko
2026-05-06 7:21 ` Maxwell Doose
2026-05-06 7:31 ` Joshua Crofts
2026-05-06 7:05 ` Joshua Crofts
2026-05-06 16:48 ` Jonathan Cameron
2026-05-06 7:07 ` Andy Shevchenko
2026-05-06 7:11 ` Maxwell Doose
2026-05-06 6:53 ` Andy Shevchenko
2026-05-06 7:07 ` Joshua Crofts
2026-05-05 11:46 ` [PATCH v5 09/18] iio: magnetometer: ak8975: avoid using temporary variable Joshua Crofts via B4 Relay
2026-05-06 16:54 ` Jonathan Cameron
2026-05-05 11:46 ` [PATCH v5 10/18] iio: magnetometer: ak8975: drop duplicate NULL check Joshua Crofts via B4 Relay
2026-05-06 16:55 ` Jonathan Cameron
2026-05-05 11:46 ` [PATCH v5 11/18] iio: magnetometer: ak8975: remove duplicate error message Joshua Crofts via B4 Relay
2026-05-06 16:56 ` Jonathan Cameron
2026-05-05 11:46 ` [PATCH v5 12/18] iio: magnetometer: ak8975: reduce usage of magic lengths of the buffer Joshua Crofts via B4 Relay
2026-05-06 16:56 ` Jonathan Cameron
2026-05-05 11:46 ` [PATCH v5 13/18] iio: magnetometer: ak8975: unify return code variable name Joshua Crofts via B4 Relay
2026-05-06 16:57 ` Jonathan Cameron
2026-05-05 11:46 ` [PATCH v5 14/18] iio: magnetometer: ak8975: switch to using managed resources Joshua Crofts via B4 Relay
2026-05-05 14:34 ` Joshua Crofts
2026-05-06 8:21 ` Andy Shevchenko
2026-05-06 17:09 ` Jonathan Cameron
2026-05-05 11:46 ` [PATCH v5 15/18] iio: magnetometer: ak8975: consistently use 'data' parameter Joshua Crofts via B4 Relay
2026-05-05 11:46 ` [PATCH v5 16/18] iio: magnetometer: ak8975: unify messages with help of dev_err_probe() Joshua Crofts via B4 Relay
2026-05-05 11:46 ` [PATCH v5 17/18] iio: magnetometer: ak8975: use temporary variable for struct device Joshua Crofts via B4 Relay
2026-05-05 11:46 ` [PATCH v5 18/18] iio: magnetometer: ak8975: make use of the macros from bits.h Joshua Crofts via B4 Relay
2026-05-06 17:12 ` Jonathan Cameron
2026-05-06 21:25 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afrrzM67n7NQWdE3@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox