From: Pasha Tatashin <pasha.tatashin@soleen.com>
To: Pratyush Yadav <pratyush@kernel.org>
Cc: Pasha Tatashin <pasha.tatashin@soleen.com>,
rppt@kernel.org, sourabhjain@linux.ibm.com, jbouron@amazon.com,
akpm@linux-foundation.org, bhe@redhat.com,
linux-kernel@vger.kernel.org, dan.carpenter@linaro.org,
liaoyuanhong@vivo.com, rafael.j.wysocki@intel.com,
piliu@redhat.com, kexec@lists.infradead.org, graf@amazon.com,
mario.limonciello@amd.com
Subject: Re: [PATCH v1 1/3] liveupdate: skip serialization for context-preserving kexec
Date: Wed, 6 May 2026 11:12:26 -0400 [thread overview]
Message-ID: <aftZZ5AuQcNuqInP@google.com> (raw)
In-Reply-To: <2vxz34050wi7.fsf@kernel.org>
On 05-06 10:31, Pratyush Yadav wrote:
> Hi Pasha,
>
> On Wed, May 06 2026, Pasha Tatashin wrote:
>
> > A preserve_context kexec returns to the current kernel, which
> > is unrelated to live update where the state is passed to the next
> > kernel. Skip liveupdate_reboot() in this case to avoid serialization
> > and prevent sessions from being left in a frozen state upon return.
>
> Should we also stop KHO? Now it is stateless and always finalized. I am
No. KHO preserves kernel internal memory; for context-preserved
kexec, the 2nd kernel and the 1st kernel do not have overlapping
memory. So, whatever the 1st kernel maintains in KHO is an internal
detail of the 1st kernel. Once we return from the 2nd kernel to the 1st
kernel, all KHO memory is going to stay as-is, and the 1st kernel can
even perform a regular kexec or live update later.
Pasha
> not sure how these kexec jump images will interact with KHO data, but
> seems like we shouldn't be handing over memory if the image will jump
> back.
>
> Anyway, for this patch:
>
> Reviewed-by: Pratyush Yadav (Google) <pratyush@kernel.org>
>
> >
> > Fixes: db8bed8082dc ("kexec: call liveupdate_reboot() before kexec")
> > Reported-by: Oskar Gerlicz Kowalczuk <oskar@gerlicz.space>
> > Signed-off-by: Pasha Tatashin <pasha.tatashin@soleen.com>
> [...]
>
> --
> Regards,
> Pratyush Yadav
next prev parent reply other threads:[~2026-05-06 15:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 4:32 [PATCH v1 0/3] liveupdate: serialization safety and race fixes Pasha Tatashin
2026-05-06 4:32 ` [PATCH v1 1/3] liveupdate: skip serialization for context-preserving kexec Pasha Tatashin
2026-05-06 8:31 ` Pratyush Yadav
2026-05-06 15:12 ` Pasha Tatashin [this message]
2026-05-06 15:33 ` Pratyush Yadav
2026-05-06 16:06 ` Pasha Tatashin
2026-05-06 4:32 ` [PATCH v1 2/3] liveupdate: block outgoing session mutations during serialization Pasha Tatashin
2026-05-06 8:47 ` Pratyush Yadav
2026-05-06 15:25 ` Pasha Tatashin
2026-05-06 4:32 ` [PATCH v1 3/3] liveupdate: pin sessions and handle inactive ones " Pasha Tatashin
2026-05-06 8:53 ` Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aftZZ5AuQcNuqInP@google.com \
--to=pasha.tatashin@soleen.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dan.carpenter@linaro.org \
--cc=graf@amazon.com \
--cc=jbouron@amazon.com \
--cc=kexec@lists.infradead.org \
--cc=liaoyuanhong@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=piliu@redhat.com \
--cc=pratyush@kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rppt@kernel.org \
--cc=sourabhjain@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox