From: Petr Mladek <pmladek@suse.com>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/vsprintf: replace min_t/max_t with min/max
Date: Thu, 21 May 2026 15:49:12 +0200 [thread overview]
Message-ID: <ag8NWBSrRvjds1_3@pathway.suse.cz> (raw)
In-Reply-To: <20260518123145.79411-3-thorsten.blum@linux.dev>
On Mon 2026-05-18 14:31:47, Thorsten Blum wrote:
> Use the simpler min()/max() macros since the values are all compatible.
>
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -1208,7 +1208,7 @@ char *hex_string(char *buf, char *end, u8 *addr, struct printf_spec spec,
> }
>
> if (spec.field_width > 0)
> - len = min_t(int, spec.field_width, 64);
> + len = min(spec.field_width, 64);
Honestly, I do not see any big advantage in replacing the macros.
In fact, the min()/max() macros are even more complex because
they check compatibility of the compared types.
IMHO, this adds non-necessary churn into the git history without
an obvious advantage.
Best Regards,
Petr
next prev parent reply other threads:[~2026-05-21 13:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 12:31 [PATCH] lib/vsprintf: replace min_t/max_t with min/max Thorsten Blum
2026-05-21 13:49 ` Petr Mladek [this message]
2026-06-02 18:02 ` Andy Shevchenko
2026-06-03 9:35 ` David Laight
2026-06-03 12:01 ` Petr Mladek
-- strict thread matches above, loose matches on Subject: below --
2026-06-02 18:21 Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ag8NWBSrRvjds1_3@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox