The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Nikolay Kulikov <nikolayof23@gmail.com>
To: Pramod Maurya <pramod.nexgen@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org,
	Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
Subject: Re: [PATCH 2/2] staging: rtl8723bs: Fix coding style in include headers
Date: Sun, 10 May 2026 20:07:30 +0300	[thread overview]
Message-ID: <agC7Us4hc7wWuYZK@archlinux> (raw)
In-Reply-To: <agC58XCiXVKdR2Lv@archlinux>

On Sun, May 10, 2026 at 08:01:37PM +0300, Nikolay Kulikov wrote:
> On Sun, May 10, 2026 at 11:17:21AM -0400, Pramod Maurya wrote:
> > Remove multiple blank lines and extern keywords from function
> > prototypes in header files as flagged by checkpatch.pl.
> 
> Please one patch for one logical change.
> 
> 
> > 
> > Files changed:
> > - rtw_wifi_regd.h: remove multiple blank lines
> > - sdio_ops_linux.h: remove multiple blank lines
> > - cmd_osdep.h: remove multiple blank lines and extern prototypes
> > - rtw_ioctl_set.h: remove multiple blank lines
> > - rtl8192c_recv.h: remove multiple blank lines
> > - rtl8723b_dm.h: remove multiple blank lines
> 
> git diff does this for you perfectly well, why repeat it?

And you haven't added cover-letter (PATCH 0/2), you can do this with:
	$ git format-patch --cover-letter ...

> 
> 
> Thanks,
> Nikolay

  reply	other threads:[~2026-05-10 17:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-10 15:17 [PATCH 1/2] staging: rtl8723bs: Remove multiple blank lines in rtw_qos.h Pramod Maurya
2026-05-10 15:17 ` [PATCH 2/2] staging: rtl8723bs: Fix coding style in include headers Pramod Maurya
2026-05-10 17:01   ` Nikolay Kulikov
2026-05-10 17:07     ` Nikolay Kulikov [this message]
2026-05-11  8:02   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=agC7Us4hc7wWuYZK@archlinux \
    --to=nikolayof23@gmail.com \
    --cc=giorgitchankvetadze1997@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=pramod.nexgen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox