Re: [PATCH v4 0/3] nolibc: Add fallocate()

[Willy Tarreau <w@1wt.eu>]

Hi Daniel,

On Thu, May 07, 2026 at 06:03:50PM +0900, Daniel Palmer wrote:
> While poking around with my "static PIE for nommu" series I found
> I needed fallocate(). Implementing it turned out a bit more
> interesting than I thought it would be due to how the offset and
> size need to be passed on 32bit machines.
> 
> v4:
>  - Added statfs()...
>  - Reworked the test a bit to use statfs() to work out if /tmp
>    is a tmpfs or not and skip the test if it isn't. This skips
>    the test on sparc32 where CONFIG_TMPFS=n.
>  - Adding the needed bits to the sparc32 config to allow tmpfs
>    to be enabled allows it to run and pass the test. I will check
>    the changes and send a patch.
>  - Cleaned up the if() around deciding how to pass the parameters
>    for fallocate() based on the comments from David and Thomas.
>  - Test passed on all of the supported targets.
(...)

Thanks, the whole series looks good to me:

Acked-by: Willy Tarreau <w@1wt.eu>

Let's wait for Thomas who usually spots finer issues than me ;-)

Thanks,
Willy