From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Breno Leitao <leitao@debian.org>
Cc: Robin van der Gracht <robin@protonic.nl>,
kernel@pengutronix.de, Oliver Hartkopp <socketcan@hartkopp.net>,
Marc Kleine-Budde <mkl@pengutronix.de>,
linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH net-next 1/2] can: j1939: convert to getsockopt_iter
Date: Mon, 11 May 2026 06:21:44 +0200 [thread overview]
Message-ID: <agFZWFwyTJGrLqKH@pengutronix.de> (raw)
In-Reply-To: <20260507-getsock_two_can-v1-1-3c2ae9edfadc@debian.org>
On Thu, May 07, 2026 at 02:34:47AM -0700, Breno Leitao wrote:
> Convert CAN J1939 socket's getsockopt implementation to use the new
> getsockopt_iter callback with sockopt_t.
>
> Key changes:
> - Replace (char __user *optval, int __user *optlen) with sockopt_t *opt
> - Use opt->optlen for buffer length (input) and returned size (output)
> - Use copy_to_iter() instead of copy_to_user()
> - Restructure the chained if/else if (which depended on put_user() being
> an expression) into a nested if/else block now that opt->optlen = len
> is a statement
> - Add linux/uio.h for copy_to_iter()
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
LGTM, Thank you!
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
Best Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2026-05-11 4:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 9:34 [PATCH net-next 0/2] net: convert remaining CAN protocols to getsockopt_iter Breno Leitao
2026-05-07 9:34 ` [PATCH net-next 1/2] can: j1939: convert " Breno Leitao
2026-05-11 4:21 ` Oleksij Rempel [this message]
2026-05-07 9:34 ` [PATCH net-next 2/2] can: isotp: " Breno Leitao
2026-05-11 7:05 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agFZWFwyTJGrLqKH@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=kernel-team@meta.com \
--cc=kernel@pengutronix.de \
--cc=leitao@debian.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=robin@protonic.nl \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox