* [PATCH] Revert "nvme: add quirk NVME_QUIRK_IGNORE_DEV_SUBNQN for 144d:a808"
[not found] ` <af2YtHjq3mhWiyJA@kbusch-mbp>
@ 2026-05-08 9:59 ` AlanCui4080
2026-05-11 15:01 ` Keith Busch
0 siblings, 1 reply; 2+ messages in thread
From: AlanCui4080 @ 2026-05-08 9:59 UTC (permalink / raw)
To: Keith Busch, linux-nvme; +Cc: linux-kernel
This reverts commit 7f991e3f9b8f044640bcb5fa8570350a68932843 ("nvme: add quirk
NVME_QUIRK_IGNORE_DEV_SUBNQN for 144d:a808")
The incorrect implementations of SUBNQN is a known issue in a massive number of
NVMe units. However, the warning "nvme nvmex: missing or invalid SUBNQN field."
is usually appropriate and will not affect performance or behavior etc. That is
because the support for SUBNQN is mandatory if the controller supports NVMe
revision 1.2.1 or greater, and it reported itself without a SUBNQN field which
breaks compliance with the specification. It should be not quirked by the Linux
Kernel.
Signed-off-by: Alan Cui <me@alancui.cc>
---
drivers/nvme/host/pci.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 9fd04cd7c5cb..2850fd55894b 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -4107,8 +4107,6 @@ static const struct pci_device_id nvme_id_table[] = {
.driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
{ PCI_DEVICE(0x1c5f, 0x0555), /* Memblaze Pblaze5 adapter */
.driver_data = NVME_QUIRK_NO_NS_DESC_LIST, },
- { PCI_DEVICE(0x144d, 0xa808), /* Samsung PM981/983 */
- .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN, },
{ PCI_DEVICE(0x144d, 0xa821), /* Samsung PM1725 */
.driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
{ PCI_DEVICE(0x144d, 0xa822), /* Samsung PM1725a */
--
2.54.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Revert "nvme: add quirk NVME_QUIRK_IGNORE_DEV_SUBNQN for 144d:a808"
2026-05-08 9:59 ` [PATCH] Revert "nvme: add quirk NVME_QUIRK_IGNORE_DEV_SUBNQN for 144d:a808" AlanCui4080
@ 2026-05-11 15:01 ` Keith Busch
0 siblings, 0 replies; 2+ messages in thread
From: Keith Busch @ 2026-05-11 15:01 UTC (permalink / raw)
To: AlanCui4080; +Cc: linux-nvme, linux-kernel
On Fri, May 08, 2026 at 05:59:12PM +0800, AlanCui4080 wrote:
> This reverts commit 7f991e3f9b8f044640bcb5fa8570350a68932843 ("nvme: add quirk
> NVME_QUIRK_IGNORE_DEV_SUBNQN for 144d:a808")
Applied to nvme-7.1, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-11 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <EgTEZ7GYRxSc3ZRAxjIuBQ@alancui.cc>
[not found] ` <af2YtHjq3mhWiyJA@kbusch-mbp>
2026-05-08 9:59 ` [PATCH] Revert "nvme: add quirk NVME_QUIRK_IGNORE_DEV_SUBNQN for 144d:a808" AlanCui4080
2026-05-11 15:01 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox