[PATCH v1 1/1] RAS/AMD/ATL: Drop malformed default N from Kconfig

[PATCH v1 1/1] RAS/AMD/ATL: Drop malformed default N from Kconfig

[Andy Shevchenko]

First of all, it has to be 'default n' (small letter n), otherwise
it looks for CONFIG_N which is absent and in case of appearance
will enable something unrelated. Second and most important is that
'default n' *is* default 'default' already. Hence just drop malformed
line.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/ras/amd/atl/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/ras/amd/atl/Kconfig b/drivers/ras/amd/atl/Kconfig
index 6e03942cd7da..44c2fd7febc5 100644
--- a/drivers/ras/amd/atl/Kconfig
+++ b/drivers/ras/amd/atl/Kconfig
@@ -12,7 +12,6 @@ config AMD_ATL
 	depends on AMD_NB && X86_64 && RAS
 	depends on AMD_NODE
 	depends on MEMORY_FAILURE
-	default N
 	help
 	  This library includes support for implementation-specific
 	  address translation procedures needed for various error
-- 
2.50.1

Re: [PATCH v1 1/1] RAS/AMD/ATL: Drop malformed default N from Kconfig

[Borislav Petkov]

On Wed, May 13, 2026 at 06:22:53PM +0200, Andy Shevchenko wrote:
> First of all, it has to be 'default n' (small letter n), otherwise
> it looks for CONFIG_N which is absent and in case of appearance

Who does look for CONFIG_N?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH v1 1/1] RAS/AMD/ATL: Drop malformed default N from Kconfig

[Andy Shevchenko]

On Wed, May 13, 2026 at 06:27:44PM +0200, Borislav Petkov wrote:
> On Wed, May 13, 2026 at 06:22:53PM +0200, Andy Shevchenko wrote:
> > First of all, it has to be 'default n' (small letter n), otherwise
> > it looks for CONFIG_N which is absent and in case of appearance

> Who does look for CONFIG_N?

Hmm... I need to rephrase that. Any suggestion how to refer to the Kconfig
symbol in a clearer way?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] RAS/AMD/ATL: Drop malformed default N from Kconfig

[Borislav Petkov]

On Wed, May 13, 2026 at 07:31:24PM +0300, Andy Shevchenko wrote:
> On Wed, May 13, 2026 at 06:27:44PM +0200, Borislav Petkov wrote:
> > On Wed, May 13, 2026 at 06:22:53PM +0200, Andy Shevchenko wrote:
> > > First of all, it has to be 'default n' (small letter n), otherwise
> > > it looks for CONFIG_N which is absent and in case of appearance
> 
> > Who does look for CONFIG_N?
> 
> Hmm... I need to rephrase that. Any suggestion how to refer to the Kconfig
> symbol in a clearer way?

So I tried searching for CONFIG_N in "make menuconfig" and it gave me many
results, but with or without your patch I didn't see a difference.

Just point to the "default" grammar definition - I see

    config NEW_NAME
        bool "New option name"
        default OLD_NAME

in Documentation/kbuild/kconfig-language.rst which says that default <symbols
in caps> refers to a symbol but the grammar should be properly documented
somewhere too (can't find it now...).

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH v1 1/1] RAS/AMD/ATL: Drop malformed default N from Kconfig

[Andy Shevchenko]

On Wed, May 13, 2026 at 07:02:40PM +0200, Borislav Petkov wrote:
> On Wed, May 13, 2026 at 07:31:24PM +0300, Andy Shevchenko wrote:
> > On Wed, May 13, 2026 at 06:27:44PM +0200, Borislav Petkov wrote:
> > > On Wed, May 13, 2026 at 06:22:53PM +0200, Andy Shevchenko wrote:
> > > > First of all, it has to be 'default n' (small letter n), otherwise
> > > > it looks for CONFIG_N which is absent and in case of appearance
> > 
> > > Who does look for CONFIG_N?
> > 
> > Hmm... I need to rephrase that. Any suggestion how to refer to the Kconfig
> > symbol in a clearer way?
> 
> So I tried searching for CONFIG_N in "make menuconfig" and it gave me many
> results, but with or without your patch I didn't see a difference.

And it has to be no difference (with all my hopes we do *not* have 'config N').

> Just point to the "default" grammar definition - I see
> 
>     config NEW_NAME
>         bool "New option name"
>         default OLD_NAME
> 
> in Documentation/kbuild/kconfig-language.rst which says that default <symbols
> in caps> refers to a symbol but the grammar should be properly documented
> somewhere too (can't find it now...).

Yeah, but here is the bug report now for dangling Kconfig symbols
https://bugzilla.kernel.org/show_bug.cgi?id=216748
this patch addresses one of the complains the bug report has.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] RAS/AMD/ATL: Drop malformed default N from Kconfig

[Borislav Petkov]

On Wed, May 13, 2026 at 08:19:49PM +0300, Andy Shevchenko wrote:
> Yeah, but here is the bug report now for dangling Kconfig symbols
> https://bugzilla.kernel.org/show_bug.cgi?id=216748
> this patch addresses one of the complains the bug report has.

But N is not dangling - AFAICT, it is a non-existant Kconfig symbol.

So the N in "default N" is evaluated as another Kconfig symbol and not as the
"no" it should be.

So can we explain *that* in the commit message in a simple, understandable
language?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH v1 1/1] RAS/AMD/ATL: Drop malformed default N from Kconfig

[Andy Shevchenko]

On Wed, May 13, 2026 at 08:04:20PM +0200, Borislav Petkov wrote:
> On Wed, May 13, 2026 at 08:19:49PM +0300, Andy Shevchenko wrote:
> > Yeah, but here is the bug report now for dangling Kconfig symbols
> > https://bugzilla.kernel.org/show_bug.cgi?id=216748
> > this patch addresses one of the complains the bug report has.
> 
> But N is not dangling - AFAICT, it is a non-existant Kconfig symbol.

> So the N in "default N" is evaluated as another Kconfig symbol and not as the
> "no" it should be.
> 
> So can we explain *that* in the commit message in a simple, understandable
> language?

Sure.


-- 
With Best Regards,
Andy Shevchenko