The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] mm/mmu_notifier: Fix a begin vs. start typo in the invalidate range comment
@ 2026-05-13 16:35 Sean Christopherson
  2026-05-13 17:12 ` David Hildenbrand (Arm)
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Sean Christopherson @ 2026-05-13 16:35 UTC (permalink / raw)
  To: Andrew Morton, David Hildenbrand
  Cc: Lorenzo Stoakes, Liam R. Howlett, Vlastimil Babka, Mike Rapoport,
	Suren Baghdasaryan, Michal Hocko, linux-mm, linux-kernel,
	Takahiro Itazuri, Sean Christopherson

From: Takahiro Itazuri <itazur@amazon.com>

Fix a goof in the block comment for invalidate_range_{start,end}() where
start() is incorrectly referred to as begin().

No functional change intended.

Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
[sean: split to separate patch, write changelog]
Signed-off-by: Sean Christopherson <seanjc@google.com>
---
 include/linux/mmu_notifier.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h
index 69c304b467df..a11a44eef521 100644
--- a/include/linux/mmu_notifier.h
+++ b/include/linux/mmu_notifier.h
@@ -134,8 +134,8 @@ struct mmu_notifier_ops {
 	 * Invalidation of multiple concurrent ranges may be
 	 * optionally permitted by the driver. Either way the
 	 * establishment of sptes is forbidden in the range passed to
-	 * invalidate_range_begin/end for the whole duration of the
-	 * invalidate_range_begin/end critical section.
+	 * invalidate_range_start/end for the whole duration of the
+	 * invalidate_range_start/end critical section.
 	 *
 	 * invalidate_range_start() is called when all pages in the
 	 * range are still mapped and have at least a refcount of one.

base-commit: 5d6919055dec134de3c40167a490f33c74c12581
-- 
2.54.0.563.g4f69b47b94-goog


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] mm/mmu_notifier: Fix a begin vs. start typo in the invalidate range comment
  2026-05-13 16:35 [PATCH] mm/mmu_notifier: Fix a begin vs. start typo in the invalidate range comment Sean Christopherson
@ 2026-05-13 17:12 ` David Hildenbrand (Arm)
  2026-05-14 10:28 ` Mike Rapoport
  2026-05-14 10:35 ` Lorenzo Stoakes
  2 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand (Arm) @ 2026-05-13 17:12 UTC (permalink / raw)
  To: Sean Christopherson, Andrew Morton
  Cc: Lorenzo Stoakes, Liam R. Howlett, Vlastimil Babka, Mike Rapoport,
	Suren Baghdasaryan, Michal Hocko, linux-mm, linux-kernel,
	Takahiro Itazuri

On 5/13/26 18:35, Sean Christopherson wrote:
> From: Takahiro Itazuri <itazur@amazon.com>
> 
> Fix a goof in the block comment for invalidate_range_{start,end}() where
> start() is incorrectly referred to as begin().
> 
> No functional change intended.
> 
> Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
> [sean: split to separate patch, write changelog]
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---

Reviewed-by: David Hildenbrand (Arm) <david@kernel.org>

-- 
Cheers,

David

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mm/mmu_notifier: Fix a begin vs. start typo in the invalidate range comment
  2026-05-13 16:35 [PATCH] mm/mmu_notifier: Fix a begin vs. start typo in the invalidate range comment Sean Christopherson
  2026-05-13 17:12 ` David Hildenbrand (Arm)
@ 2026-05-14 10:28 ` Mike Rapoport
  2026-05-14 10:35 ` Lorenzo Stoakes
  2 siblings, 0 replies; 4+ messages in thread
From: Mike Rapoport @ 2026-05-14 10:28 UTC (permalink / raw)
  To: Sean Christopherson
  Cc: Andrew Morton, David Hildenbrand, Lorenzo Stoakes,
	Liam R. Howlett, Vlastimil Babka, Suren Baghdasaryan,
	Michal Hocko, linux-mm, linux-kernel, Takahiro Itazuri

On Wed, May 13, 2026 at 09:35:46AM -0700, Sean Christopherson wrote:
> From: Takahiro Itazuri <itazur@amazon.com>
> 
> Fix a goof in the block comment for invalidate_range_{start,end}() where
> start() is incorrectly referred to as begin().
> 
> No functional change intended.
> 
> Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
> [sean: split to separate patch, write changelog]
> Signed-off-by: Sean Christopherson <seanjc@google.com>

Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>

> ---
>  include/linux/mmu_notifier.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h
> index 69c304b467df..a11a44eef521 100644
> --- a/include/linux/mmu_notifier.h
> +++ b/include/linux/mmu_notifier.h
> @@ -134,8 +134,8 @@ struct mmu_notifier_ops {
>  	 * Invalidation of multiple concurrent ranges may be
>  	 * optionally permitted by the driver. Either way the
>  	 * establishment of sptes is forbidden in the range passed to
> -	 * invalidate_range_begin/end for the whole duration of the
> -	 * invalidate_range_begin/end critical section.
> +	 * invalidate_range_start/end for the whole duration of the
> +	 * invalidate_range_start/end critical section.
>  	 *
>  	 * invalidate_range_start() is called when all pages in the
>  	 * range are still mapped and have at least a refcount of one.
> 
> base-commit: 5d6919055dec134de3c40167a490f33c74c12581
> -- 
> 2.54.0.563.g4f69b47b94-goog
> 

-- 
Sincerely yours,
Mike.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mm/mmu_notifier: Fix a begin vs. start typo in the invalidate range comment
  2026-05-13 16:35 [PATCH] mm/mmu_notifier: Fix a begin vs. start typo in the invalidate range comment Sean Christopherson
  2026-05-13 17:12 ` David Hildenbrand (Arm)
  2026-05-14 10:28 ` Mike Rapoport
@ 2026-05-14 10:35 ` Lorenzo Stoakes
  2 siblings, 0 replies; 4+ messages in thread
From: Lorenzo Stoakes @ 2026-05-14 10:35 UTC (permalink / raw)
  To: Sean Christopherson
  Cc: Andrew Morton, David Hildenbrand, Liam R. Howlett,
	Vlastimil Babka, Mike Rapoport, Suren Baghdasaryan, Michal Hocko,
	linux-mm, linux-kernel, Takahiro Itazuri

On Wed, May 13, 2026 at 09:35:46AM -0700, Sean Christopherson wrote:
> From: Takahiro Itazuri <itazur@amazon.com>
>
> Fix a goof in the block comment for invalidate_range_{start,end}() where
> start() is incorrectly referred to as begin().
>
> No functional change intended.
>
> Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
> [sean: split to separate patch, write changelog]
> Signed-off-by: Sean Christopherson <seanjc@google.com>

LGTM, so:

Reviewed-by: Lorenzo Stoakes <ljs@kernel.org>

> ---
>  include/linux/mmu_notifier.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h
> index 69c304b467df..a11a44eef521 100644
> --- a/include/linux/mmu_notifier.h
> +++ b/include/linux/mmu_notifier.h
> @@ -134,8 +134,8 @@ struct mmu_notifier_ops {
>  	 * Invalidation of multiple concurrent ranges may be
>  	 * optionally permitted by the driver. Either way the
>  	 * establishment of sptes is forbidden in the range passed to
> -	 * invalidate_range_begin/end for the whole duration of the
> -	 * invalidate_range_begin/end critical section.
> +	 * invalidate_range_start/end for the whole duration of the
> +	 * invalidate_range_start/end critical section.
>  	 *
>  	 * invalidate_range_start() is called when all pages in the
>  	 * range are still mapped and have at least a refcount of one.
>
> base-commit: 5d6919055dec134de3c40167a490f33c74c12581
> --
> 2.54.0.563.g4f69b47b94-goog
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-05-14 10:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-13 16:35 [PATCH] mm/mmu_notifier: Fix a begin vs. start typo in the invalidate range comment Sean Christopherson
2026-05-13 17:12 ` David Hildenbrand (Arm)
2026-05-14 10:28 ` Mike Rapoport
2026-05-14 10:35 ` Lorenzo Stoakes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox