From: Willy Tarreau <w@1wt.eu>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] tools/nolibc: always pass mode to open syscall
Date: Thu, 14 May 2026 17:32:31 +0200 [thread overview]
Message-ID: <agXrDxorQP5dtPFM@1wt.eu> (raw)
In-Reply-To: <20260514-nolibc-open-tmpfile-v2-3-b4c6c5efa266@weissschuh.net>
Hi Thomas,
On Thu, May 14, 2026 at 02:05:13PM +0200, Thomas Weißschuh wrote:
> When O_TMPFILE is set, the open mode needs to be passed to the kernel as
> per the documentation. Currently this is not done.
> Instead of checking for O_TMPFILE explicitly and making the conditionals
> more complex, just always pass the mode to the kernel. If no value was
> passed the mode will be garbage, but the kernel will ignore it anyways.
>
> Fixes: a7604ba149e7 ("tools/nolibc/sys: make open() take a vararg on the 3rd argument")
> Suggested-by: Willy Tarreau <w@1wt.eu>
> Link: https://lore.kernel.org/lkml/afRfjdovT6pNtwtP@1wt.eu/
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Looks good, thank you for making this one move forward!
Acked-by: Willy Tarreau <w@1wt.eu>
Willy
next prev parent reply other threads:[~2026-05-14 15:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 12:05 [PATCH v2 0/4] tools/nolibc: pass mode to open syscall if O_TMPFILE is set Thomas Weißschuh
2026-05-14 12:05 ` [PATCH v2 1/4] tools/nolibc: split implicit open flags into a macro Thomas Weißschuh
2026-05-14 12:05 ` [PATCH v2 2/4] tools/nolibc: split open mode handling " Thomas Weißschuh
2026-05-14 12:05 ` [PATCH v2 3/4] tools/nolibc: always pass mode to open syscall Thomas Weißschuh
2026-05-14 15:32 ` Willy Tarreau [this message]
2026-05-14 12:05 ` [PATCH v2 4/4] selftests/nolibc: test open mode handling Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agXrDxorQP5dtPFM@1wt.eu \
--to=w@1wt.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox