From: Dan Carpenter <error27@gmail.com>
To: Yousef Alhouseen <alhouseenyousef@gmail.com>
Cc: Vaibhav Agarwal <vaibhav.sr@gmail.com>,
Mark Greer <mgreer@animalcreek.com>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: add missing newlines to sysfs_emit() output
Date: Sat, 16 May 2026 13:13:52 +0300 [thread overview]
Message-ID: <aghDYN3B53QOUMM-@stanley.mountain> (raw)
In-Reply-To: <20260515223342.40869-1-alhouseenyousef@gmail.com>
On Sat, May 16, 2026 at 12:33:42AM +0200, Yousef Alhouseen wrote:
> Sysfs show() callbacks should emit a trailing newline for text output.
> Several Greybus audio manager module attributes currently omit the
> newline, which triggers checkpatch warnings and makes the attributes less
> convenient to read from userspace.
>
> Append missing newlines to the affected sysfs_emit() format strings.
>
> Signed-off-by: Yousef Alhouseen <alhouseenyousef@gmail.com>
> ---
Patches which affect the user space ABI need to be tested properly
before they can be merged. It's just to risky to start changing things
randomly. If it were fixing something then that would be different, but
just making checkpatch happy is not motivation enough.
regards,
dan carpenter
prev parent reply other threads:[~2026-05-16 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 22:33 [PATCH] staging: greybus: add missing newlines to sysfs_emit() output Yousef Alhouseen
2026-05-16 6:57 ` Greg Kroah-Hartman
2026-05-16 10:13 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aghDYN3B53QOUMM-@stanley.mountain \
--to=error27@gmail.com \
--cc=alhouseenyousef@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mgreer@animalcreek.com \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox