From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Rich Felker <dalias@libc.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Arnd Bergmann <arnd@kernel.org>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2 3/5] sh: mach-rsk: rsk7203: use static device properties for LEDs and GPIO buttons
Date: Tue, 2 Jun 2026 16:52:37 -0700 [thread overview]
Message-ID: <ah9rmXIlZZUHAgag@google.com> (raw)
In-Reply-To: <ah9rHgAvprCTwEed@ashevche-desk.local>
On Wed, Jun 03, 2026 at 02:45:34AM +0300, Andy Shevchenko wrote:
> On Tue, Jun 02, 2026 at 03:06:14PM -0700, Dmitry Torokhov wrote:
> > On Wed, Jun 03, 2026 at 01:02:56AM +0300, Andy Shevchenko wrote:
> > > On Wed, May 20, 2026 at 10:13:19PM -0700, Dmitry Torokhov wrote:
>
> ...
>
> > > > + for (i = 0; i < ARRAY_SIZE(rsk7203_devices); i++) {
> > >
> > > for (unsigned int i = 0; i < ARRAY_SIZE(rsk7203_devices); i++) {
> > >
> > > ...and drop the above definition of i.
> >
> > Why? I do not see coding style suggesting this.
>
> Linus Torvalds.
Context matters.
If you want this to be a universal requirement work on adding this to
coding style and to checkpatch. Otherwise declaring loop iterator inside
the loop can be beneficial but in many cases it does not really matter
and can be left to the code author and the revealing style for the
affected code area.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2026-06-02 23:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 5:13 [PATCH v2 0/5] rsk7203: switch to using static device property, drop legacy gpio API Dmitry Torokhov
2026-05-21 5:13 ` [PATCH v2 1/5] pinctrl: renesas: gpio: isolate function gpiochip from parent fwnode Dmitry Torokhov
2026-05-21 9:09 ` Bartosz Golaszewski
2026-05-21 5:13 ` [PATCH v2 2/5] sh: pfc: attach software node to the GPIO chip Dmitry Torokhov
2026-05-21 9:12 ` Bartosz Golaszewski
2026-05-21 5:13 ` [PATCH v2 3/5] sh: mach-rsk: rsk7203: use static device properties for LEDs and GPIO buttons Dmitry Torokhov
2026-05-21 9:12 ` Bartosz Golaszewski
2026-06-02 22:02 ` Andy Shevchenko
2026-06-02 22:06 ` Dmitry Torokhov
2026-06-02 23:45 ` Andy Shevchenko
2026-06-02 23:52 ` Andy Shevchenko
2026-06-02 23:52 ` Dmitry Torokhov [this message]
2026-06-03 0:10 ` Andy Shevchenko
2026-05-21 5:13 ` [PATCH v2 4/5] pinctrl: renesas: gpio: support software nodes for function GPIOs Dmitry Torokhov
2026-05-21 9:13 ` Bartosz Golaszewski
2026-05-21 5:13 ` [PATCH v2 5/5] sh: mach-rsk: rsk7203: convert pin configuration to using software nodes Dmitry Torokhov
2026-05-21 9:14 ` Bartosz Golaszewski
2026-05-25 8:56 ` [PATCH v2 0/5] rsk7203: switch to using static device property, drop legacy gpio API Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ah9rmXIlZZUHAgag@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@kernel.org \
--cc=brgl@kernel.org \
--cc=dalias@libc.org \
--cc=geert+renesas@glider.be \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox