Re: [PATCH] staging: rtl8723bs: clean up coding style in sdio_intf.c

[Dan Carpenter <error27@gmail.com>]

On Thu, May 28, 2026 at 09:44:15PM +0300, Vitaliy Slivinskiy wrote:
> Fix checkpatch.pl warnings: remove unnecessary braces for single statement blocks, fix spacing around conditional operators, and remove multiple blank lines.
> 

Work against the staging-next tree.
Split this up into multiple patches.
Run your patch through checkpatch.


> Signed-off-by: Vitaliy Slivinskiy <phant0m.mail2023@gmail.com>
> ---
>  drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 18 ++++++------------
>  1 file changed, 6 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> index d0feb28b7..17829b982 100644
> --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> @@ -19,7 +19,7 @@ static const struct sdio_device_id sdio_ids[] = {
>  	{ SDIO_DEVICE(0x024c, 0x0626), },
>  	{ SDIO_DEVICE(0x024c, 0x0627), },
>  	{ SDIO_DEVICE(0x024c, 0xb723), },
> -	{ /* end: all zeroes */				},
> +	{ /* end: all zeroes */		   },

This should just be:

	{ }

No comment because it's obvious.  No comma on the end because
nothing can be added after a sentinal.

>  };
>  MODULE_DEVICE_TABLE(sdio, sdio_ids);

regards,
dan carpenter