* [PATCH] staging: rtl8723bs: add braces to resolve checkpatch
@ 2026-06-04 17:39 Dalvin-Ehinoma Noah Aiguobas
2026-06-04 21:34 ` Ethan Tidmore
0 siblings, 1 reply; 2+ messages in thread
From: Dalvin-Ehinoma Noah Aiguobas @ 2026-06-04 17:39 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel
Resolved checkpatch finding by adding braces as shown in styleguide.
Signed-off-by: Dalvin-Ehinoma Noah Aiguobas <fliegbert2@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
index d0bbe1bb979c..8d4bcf7ebeaf 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
@@ -472,8 +472,9 @@ int rtw_parse_wpa_ie(u8 *wpa_ie, int wpa_ie_len, int *group_cipher, int *pairwis
pos += WPA_SELECTOR_LEN;
left -= WPA_SELECTOR_LEN;
- } else if (left > 0)
+ } else if (left > 0) {
return _FAIL;
+ }
/* pairwise_cipher */
if (left >= 2) {
@@ -492,8 +493,9 @@ int rtw_parse_wpa_ie(u8 *wpa_ie, int wpa_ie_len, int *group_cipher, int *pairwis
left -= WPA_SELECTOR_LEN;
}
- } else if (left == 1)
+ } else if (left == 1) {
return _FAIL;
+ }
if (is_8021x) {
if (left >= 6) {
@@ -532,8 +534,9 @@ int rtw_parse_wpa2_ie(u8 *rsn_ie, int rsn_ie_len, int *group_cipher, int *pairwi
pos += RSN_SELECTOR_LEN;
left -= RSN_SELECTOR_LEN;
- } else if (left > 0)
+ } else if (left > 0) {
return _FAIL;
+ }
/* pairwise_cipher */
if (left >= 2) {
@@ -552,8 +555,9 @@ int rtw_parse_wpa2_ie(u8 *rsn_ie, int rsn_ie_len, int *group_cipher, int *pairwi
left -= RSN_SELECTOR_LEN;
}
- } else if (left == 1)
+ } else if (left == 1) {
return _FAIL;
+ }
if (is_8021x) {
if (left >= 6) {
--
2.54.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8723bs: add braces to resolve checkpatch
2026-06-04 17:39 [PATCH] staging: rtl8723bs: add braces to resolve checkpatch Dalvin-Ehinoma Noah Aiguobas
@ 2026-06-04 21:34 ` Ethan Tidmore
0 siblings, 0 replies; 2+ messages in thread
From: Ethan Tidmore @ 2026-06-04 21:34 UTC (permalink / raw)
To: Dalvin-Ehinoma Noah Aiguobas, gregkh; +Cc: linux-staging, linux-kernel
On Thu Jun 4, 2026 at 12:39 PM CDT, Dalvin-Ehinoma Noah Aiguobas wrote:
> Resolved checkpatch finding by adding braces as shown in styleguide.
>
> Signed-off-by: Dalvin-Ehinoma Noah Aiguobas <fliegbert2@gmail.com>
> ---
The patch notes should describe what the patch does, not the tool used
to find the issue.
Thanks,
ET
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-04 21:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-04 17:39 [PATCH] staging: rtl8723bs: add braces to resolve checkpatch Dalvin-Ehinoma Noah Aiguobas
2026-06-04 21:34 ` Ethan Tidmore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox