From: Vishal Moola <vishal.moola@gmail.com>
To: SeongJae Park <sj@kernel.org>
Cc: Yichong Chen <chenyichong@uniontech.com>,
akpm@linux-foundation.org, penberg@cs.helsinki.fi,
clameter@sgi.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/mm/slabinfo: fix total_objects attribute name
Date: Mon, 15 Jun 2026 13:41:28 +0100 [thread overview]
Message-ID: <ai_y-I5Vd0MUS383@fedora> (raw)
In-Reply-To: <20260613002913.1509-1-sj@kernel.org>
On Fri, Jun 12, 2026 at 05:29:12PM -0700, SeongJae Park wrote:
> On Fri, 12 Jun 2026 15:13:59 +0800 Yichong Chen <chenyichong@uniontech.com> wrote:
>
> > SLUB exports the total_objects sysfs attribute, but slabinfo tries to read
> > objects_total. As a result, the lookup fails and the field remains zero.
> >
> > Use the correct attribute name and rename the corresponding structure
> > member to match.
>
> Good finding, thank you for fixing this!
>
> >
> > Fixes: 205ab99dd103 ("slub: Update statistics handling for variable order slabs")
>
> Should we add Cc: stable@ ?
This variable isn't even used... so we don't need a cc stable. That's
probably why no one spotted it until now too ;)
We should probably be printing it out in another column; I'm not sure
why the initial patch didn't do so.
> > Signed-off-by: Yichong Chen <chenyichong@uniontech.com>
>
> Reviewed-by: SeongJae Park <sj@kernel.org>
>
>
> Thanks,
> SJ
>
> [...]
prev parent reply other threads:[~2026-06-15 12:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 7:13 [PATCH] tools/mm/slabinfo: fix total_objects attribute name Yichong Chen
2026-06-13 0:29 ` SeongJae Park
2026-06-13 5:20 ` Yichong Chen
2026-06-15 12:41 ` Vishal Moola [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ai_y-I5Vd0MUS383@fedora \
--to=vishal.moola@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chenyichong@uniontech.com \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox