* [PATCH] orangefs: Remove commented out code in find_cached_xattr
@ 2025-12-21 12:47 Thorsten Blum
2026-06-11 22:08 ` Thorsten Blum
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2025-12-21 12:47 UTC (permalink / raw)
To: Mike Marshall, Martin Brandenburg; +Cc: Thorsten Blum, devel, linux-kernel
The code has been commented out since 2017 - remove it.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
fs/orangefs/xattr.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/fs/orangefs/xattr.c b/fs/orangefs/xattr.c
index eee3c5ed1bbb..4043942a3c33 100644
--- a/fs/orangefs/xattr.c
+++ b/fs/orangefs/xattr.c
@@ -72,11 +72,6 @@ static struct orangefs_cached_xattr *find_cached_xattr(struct inode *inode,
if (hlist_empty(h))
return NULL;
hlist_for_each_entry_safe(cx, tmp, h, node) {
-/* if (!time_before(jiffies, cx->timeout)) {
- hlist_del(&cx->node);
- kfree(cx);
- continue;
- }*/
if (!strcmp(cx->key, key))
return cx;
}
--
Thorsten Blum <thorsten.blum@linux.dev>
GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] orangefs: Remove commented out code in find_cached_xattr
2025-12-21 12:47 [PATCH] orangefs: Remove commented out code in find_cached_xattr Thorsten Blum
@ 2026-06-11 22:08 ` Thorsten Blum
0 siblings, 0 replies; 2+ messages in thread
From: Thorsten Blum @ 2026-06-11 22:08 UTC (permalink / raw)
To: Mike Marshall, Martin Brandenburg; +Cc: devel, linux-kernel
Gentle ping or do you prefer to keep this for some reason?
On Sun, Dec 21, 2025 at 01:47:13PM +0100, Thorsten Blum wrote:
> The code has been commented out since 2017 - remove it.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> fs/orangefs/xattr.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/fs/orangefs/xattr.c b/fs/orangefs/xattr.c
> index eee3c5ed1bbb..4043942a3c33 100644
> --- a/fs/orangefs/xattr.c
> +++ b/fs/orangefs/xattr.c
> @@ -72,11 +72,6 @@ static struct orangefs_cached_xattr *find_cached_xattr(struct inode *inode,
> if (hlist_empty(h))
> return NULL;
> hlist_for_each_entry_safe(cx, tmp, h, node) {
> -/* if (!time_before(jiffies, cx->timeout)) {
> - hlist_del(&cx->node);
> - kfree(cx);
> - continue;
> - }*/
> if (!strcmp(cx->key, key))
> return cx;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-11 22:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-21 12:47 [PATCH] orangefs: Remove commented out code in find_cached_xattr Thorsten Blum
2026-06-11 22:08 ` Thorsten Blum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox