From: Matt Fleming <matt@readmodwrite.com>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Tejun Heo <tj@kernel.org>, Andrea Righi <arighi@nvidia.com>,
sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org,
kernel-team@cloudflare.com
Subject: Re: sched_ext/lavd hard lockup in old call_rcu_tasks_generic needadjust path
Date: Fri, 12 Jun 2026 11:55:57 +0100 [thread overview]
Message-ID: <aivaGbCzC4oaD05n@matt-Precision-5490> (raw)
In-Reply-To: <1ad83f53-7897-40bc-a503-5a71031aa27f@paulmck-laptop>
On Thu, Jun 11, 2026 at 06:45:14AM -0700, Paul E. McKenney wrote:
> On Thu, Jun 11, 2026 at 02:02:58PM +0100, Matt Fleming wrote:
> > On Tue, Jun 09, 2026 at 04:23:23AM -0700, Paul E. McKenney wrote:
> > >
> > > Does commenting out the 'call_rcu_tasks_generic+547' printk() avoid the
> > > issue? If so, that printk() might be deferred or some such.
> > >
> > > "But if you cannot trust printk(), what *can* you trust?" ;-)
> >
> > I tried this and it still crashes so apparently not! I'll keep digging
> > to find the real cause (it's somewhat cumbersome to reproduce this hard
> > lockup).
>
> If this code path is nevertheless involved, one thing that might speed
> things up would be to do bursts of call_rcu_tasks() from lots of CPUs,
> then avoid doing any call_rcu_tasks() for some time, then do a single
> isolated call_rcu_tasks(). Or maybe you are already doing this.
Thanks, I managed to shrink the time to reproduce the lockup and it's
now clear that the bug is an ABBA deadlock on cbs_gbl_lock.
CPU #1
==========
sched_ext_free()
task_rq_lock() // acquires rq->lock
scx_exit_task()
SCX_CALL_OP_TASK(.exit_task)
bpf_task_storage_delete()
bpf_selem_unlink()
bpf_selem_unlink_storage()
bpf_selem_free()
call_rcu_tasks_trace()
call_rcu_tasks_generic()
raw_spin_lock(cbs_gbl_lock) // BLOCKS: CPU #2 owns it
CPU #2
==========
rcu_tasks_kthread()
rcu_tasks_one_gp()
raw_spin_lock(cbs_gbl_lock) // acquired
pr_info("Starting switch ...") // still under cbs_gbl_lock
console_unlock()
wake_up_q()
try_to_wake_up(repro)
raw_spin_lock(rq->lock) // BLOCKS: CPU #1 owns it
Given this, I can see why removing the single printk() didn't fix
anything, and we can expect any code path under cbs_gbl_lock that wakes
a task could trigger this hard lockup. Right now in 6.18 that's a few
printk()s and a WARN_ON_ONCE().
This issue doesn't exist in v7.0-rc1 because of commit c27cea4416a3
("rcu: Re-implement RCU Tasks Trace in terms of SRCU-fast").
Is there an easy way to defer call_rcu_tasks_generic() work so it gets
executed without rq->lock being held? I'm assuming backporting the SRCU
patches would be too invasive for LTS?
Thanks,
Matt
next prev parent reply other threads:[~2026-06-12 10:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 10:47 sched_ext/lavd hard lockup in old call_rcu_tasks_generic needadjust path Matt Fleming
2026-06-09 11:23 ` Paul E. McKenney
2026-06-11 13:02 ` Matt Fleming
2026-06-11 13:45 ` Paul E. McKenney
2026-06-12 10:55 ` Matt Fleming [this message]
2026-06-12 14:00 ` Paul E. McKenney
2026-06-16 10:56 ` Matt Fleming
2026-06-17 3:24 ` Paul E. McKenney
2026-06-18 6:56 ` Matt Fleming
2026-06-18 15:55 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aivaGbCzC4oaD05n@matt-Precision-5490 \
--to=matt@readmodwrite.com \
--cc=arighi@nvidia.com \
--cc=kernel-team@cloudflare.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=sched-ext@lists.linux.dev \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox