From: Thorsten Blum <thorsten.blum@linux.dev>
To: Borislav Petkov <bp@alien8.de>
Cc: Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/boot: Reject truncated acpi_rsdp= values
Date: Fri, 19 Jun 2026 23:43:18 +0200 [thread overview]
Message-ID: <ajW39gZ9YuY6da6w@linux.dev> (raw)
In-Reply-To: <20260619202421.GAajWlddFHPr1hl7AD@fat_crate.local>
On Fri, Jun 19, 2026 at 01:24:21PM -0700, Borislav Petkov wrote:
> On Fri, Jun 19, 2026 at 09:57:58AM +0200, Thorsten Blum wrote:
> > Are you perhaps appending nokaslr?
>
> Yes, removed it. Same thing.
>
> > With the latest Linus tree, defconfig, and CONFIG_MEMORY_HOTREMOVE=y,
> > this crashes reproducibly for me, but only when KASLR is not disabled:
> >
> > qemu-system-x86_64 -nographic -no-reboot -kernel arch/x86/boot/bzImage -append "console=ttyS0 acpi_rsdp=0x0123456789abcdefx"
>
> As said, efistub entry point bypassing get_cmdline_acpi_rsdp():
>
> ...
> -drive if=pflash,format=raw,unit=0,file=/home/boris/kvm/debian/uefi/OVMF_CODE_4M-sid-uefi.fd,readonly=on
> -drive if=pflash,format=raw,unit=1,file=/home/boris/kvm/debian/uefi/OVMF_VARS_4M-sid-uefi.fd,readonly=of
> ...
>
> So I can't reproduce it.
Right, but that is a different setup, which bypasses
get_cmdline_acpi_rsdp() and is not expected to reproduce this bug.
Could you please try the exact direct kernel boot reproducer I provided,
using defconfig and CONFIG_MEMORY_HOTREMOVE=y?
$ qemu-system-x86_64 -nographic -no-reboot -kernel arch/x86/boot/bzImage -append "console=ttyS0 acpi_rsdp=0x0123456789abcdefx"
That path reaches get_cmdline_acpi_rsdp() and should crash during early
boot without the patch. Thanks.
prev parent reply other threads:[~2026-06-19 21:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-17 13:04 [PATCH] x86/boot: Reject truncated acpi_rsdp= values Thorsten Blum
2026-06-18 4:54 ` Borislav Petkov
2026-06-18 15:03 ` Thorsten Blum
2026-06-18 16:38 ` Borislav Petkov
2026-06-18 17:59 ` Thorsten Blum
2026-06-18 18:04 ` Borislav Petkov
2026-06-18 18:57 ` Thorsten Blum
2026-06-18 19:34 ` Borislav Petkov
2026-06-19 1:00 ` Thorsten Blum
2026-06-19 2:48 ` Borislav Petkov
2026-06-19 7:57 ` Thorsten Blum
2026-06-19 20:24 ` Borislav Petkov
2026-06-19 21:43 ` Thorsten Blum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajW39gZ9YuY6da6w@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox