From: Nicolin Chen <nicolinc@nvidia.com>
To: Ashish Mhetre <amhetre@nvidia.com>
Cc: <will@kernel.org>, <robin.murphy@arm.com>, <joro@8bytes.org>,
<jgg@ziepe.ca>, <linux-arm-kernel@lists.infradead.org>,
<iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<linux-tegra@vger.kernel.org>
Subject: Re: [PATCH v4 2/3] iommu/arm-smmu-v3: Detect Tegra264 erratum
Date: Wed, 8 Jul 2026 18:41:56 -0700 [thread overview]
Message-ID: <ak78ZKr1fxASWwl4@nvidia.com> (raw)
In-Reply-To: <20260609073204.1760077-3-amhetre@nvidia.com>
On Tue, Jun 09, 2026 at 07:32:03AM +0000, Ashish Mhetre wrote:
> @@ -5303,8 +5305,11 @@ static int arm_smmu_device_dt_probe(struct platform_device *pdev,
> if (of_dma_is_coherent(dev->of_node))
> smmu->features |= ARM_SMMU_FEAT_COHERENCY;
>
> - if (of_device_is_compatible(dev->of_node, "nvidia,tegra264-smmu"))
> + if (of_device_is_compatible(dev->of_node, "nvidia,tegra264-smmu")) {
> tegra_cmdqv_dt_probe(dev->of_node, smmu);
> + smmu->options |= ARM_SMMU_OPT_REPEAT_TLBI_CFGI;
> + static_branch_enable(&arm_smmu_erratum_repeat_tlbi_cfgi_key);
> + }
This would be nicer to be the last part of the series. Since we
need a respin, I would change the order a bit:
patch-1 factor a helper for force_sync
patch-2 define a static key and its WAR functions
patch-3 detect per compatible string and set the key
Nicolin
next prev parent reply other threads:[~2026-07-09 1:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 7:32 [PATCH v4 0/3] iommu/arm-smmu-v3: Tegra264 invalidation workaround Ashish Mhetre
2026-06-09 7:32 ` [PATCH v4 1/3] iommu/arm-smmu-v3: Factor out CMDQ batch force-sync conditions Ashish Mhetre
2026-06-09 7:32 ` [PATCH v4 2/3] iommu/arm-smmu-v3: Detect Tegra264 erratum Ashish Mhetre
2026-07-07 23:25 ` Nicolin Chen
2026-07-08 14:12 ` Ashish Mhetre
2026-07-09 0:52 ` Nicolin Chen
2026-07-09 1:41 ` Nicolin Chen [this message]
2026-06-09 7:32 ` [PATCH v4 3/3] iommu/arm-smmu-v3: Issue CFGI/TLBI twice on Tegra264 Ashish Mhetre
2026-06-17 3:58 ` [PATCH v4 0/3] iommu/arm-smmu-v3: Tegra264 invalidation workaround Ashish Mhetre
2026-06-17 4:54 ` Nicolin Chen
2026-06-17 8:21 ` Jon Hunter
2026-06-29 4:11 ` Ashish Mhetre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak78ZKr1fxASWwl4@nvidia.com \
--to=nicolinc@nvidia.com \
--cc=amhetre@nvidia.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox