From: Dan Carpenter <error27@gmail.com>
To: phucduc.bui@gmail.com
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
cassiogabrielcontato@gmail.com, Kees Cook <kees@kernel.org>,
Cen Zhang <zzzccc427@gmail.com>, Len Bao <len.bao@gmx.us>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: oss: Drop redundant nonseekable_open() return check
Date: Thu, 9 Jul 2026 13:07:48 +0300 [thread overview]
Message-ID: <ak9y9Nlxz2lu4ObE@stanley.mountain> (raw)
In-Reply-To: <ak9xV8VdUT91gHZk@stanley.mountain>
On Thu, Jul 09, 2026 at 01:00:55PM +0300, Dan Carpenter wrote:
> On Thu, Jul 02, 2026 at 12:02:36PM +0700, phucduc.bui@gmail.com wrote:
> > From: bui duc phuc <phucduc.bui@gmail.com>
> >
> > nonseekable_open() always returns 0, so the error check is unnecessary.
> > Remove the dead error handling path.
>
> The idea is that it might return errors in the future.
>
Actually the comments on nonseekable_open() say there is no need to
check. That would have been useful information to add in the commit
message...
> Also the patch is kind of sloppy...
The sloppiness was fixed in v2. It's weird that there were no review
comments on lore for this patch. Are people sending private reviews
now?
regards,
dan carpenter
next prev parent reply other threads:[~2026-07-09 10:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 5:02 [PATCH] ALSA: oss: Drop redundant nonseekable_open() return check phucduc.bui
2026-07-09 10:00 ` Dan Carpenter
2026-07-09 10:07 ` Dan Carpenter [this message]
2026-07-09 10:56 ` Bui Duc Phuc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak9y9Nlxz2lu4ObE@stanley.mountain \
--to=error27@gmail.com \
--cc=cassiogabrielcontato@gmail.com \
--cc=kees@kernel.org \
--cc=len.bao@gmx.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=phucduc.bui@gmail.com \
--cc=tiwai@suse.com \
--cc=zzzccc427@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox