From: Dan Carpenter <error27@gmail.com>
To: adi25charis@gmail.com
Cc: vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org,
elder@kernel.org, gregkh@linuxfoundation.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: audio: split topology get into size and data calls
Date: Tue, 30 Jun 2026 15:16:59 +0300 [thread overview]
Message-ID: <akOzu5aBoPgNvuoo@stanley.mountain> (raw)
In-Reply-To: <akOy6ORYkzHxodYU@stanley.mountain>
On Tue, Jun 30, 2026 at 03:13:28PM +0300, Dan Carpenter wrote:
> On Mon, Jun 29, 2026 at 08:19:41PM +0530, adi25charis@gmail.com wrote:
> > + topology = kzalloc(size, GFP_KERNEL);
> > + if (!topology) {
> > + ret = -ENOMEM;
> > goto disable_connection;
> > }
> >
> > + ret = gb_audio_gb_get_topology(gbmodule->mgmt_connection, topology, size);
>
> It's unfortunate that we don't save the size anywhere. This code
> relies on trusting the firmware for its security. It would be better
> to move away from that.
>
(just ignore this comment. It's just random thoughts, not related to
your patch. Someone took some steps to try make this code less trusting
recently).
regards,
dan carpenter
next prev parent reply other threads:[~2026-06-30 12:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 14:49 [PATCH] staging: greybus: audio: split topology get into size and data calls adi25charis
2026-06-30 12:13 ` Dan Carpenter
2026-06-30 12:16 ` Dan Carpenter [this message]
2026-06-30 16:46 ` [PATCH v2] staging: greybus: audio: split gb_audio_gb_get_topology() adi25charis
2026-06-30 18:59 ` Dan Carpenter
2026-06-30 20:49 ` [PATCH v2] staging: greybus: audio: split topology get into size and data calls adi25charis
2026-07-01 5:04 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akOzu5aBoPgNvuoo@stanley.mountain \
--to=error27@gmail.com \
--cc=adi25charis@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mgreer@animalcreek.com \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox