[PATCH v2] media: atomisp: fix block comment formatting style

[PATCH v2] media: atomisp: fix block comment formatting style

[Bohdan D. Marcus]

Fix a block comment formatting warning reported by checkpatch.pl in atomisp_cmd.c to conform to the Linux kernel coding style.

Signed-off-by: Bohdan D. Marcus <bohdandmarcus@gmail.com>
---
 drivers/staging/media/atomisp/pci/atomisp_cmd.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
index 6cd500d9fd26..20abc2c0de80 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
@@ -2520,9 +2520,12 @@ int atomisp_css_cp_dvs2_coefs(struct atomisp_sub_device *asd,
 		if (sizeof(*cur) != sizeof(dvs2_coefs.grid) ||
 		    memcmp(&dvs2_coefs.grid, cur, sizeof(dvs2_coefs.grid))) {
 			dev_err(asd->isp->dev, "dvs grid mismatch!\n");
-			/* If the grid info in the argument differs from the current
-			grid info, we tell the caller to reset the grid size and
-			try again. */
+						/*
+						 * If the grid info in the argument differs
+						 * from the current grid info, we tell the
+						 * caller to reset the grid size and try
+						 * again.
+						 */
 			return -EAGAIN;
 		}
 
-- 
2.55.0

Re: [PATCH v2] media: atomisp: fix block comment formatting style

[Dan Carpenter]

On Tue, Jun 30, 2026 at 04:26:31PM +0300, Bohdan D. Marcus wrote:
> Fix a block comment formatting warning reported by checkpatch.pl in atomisp_cmd.c to conform to the Linux kernel coding style.
> 

Run checkpatch on your patch.

> Signed-off-by: Bohdan D. Marcus <bohdandmarcus@gmail.com>
> ---

There is a specific format for v2 patches.

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

But the main thing is to wait a day between resends otherwise it's
overwhelming for reviewers.

regards,
dan carpenter

Re: [PATCH v2] media: atomisp: fix block comment formatting style

[Andy Shevchenko]

On Tue, Jun 30, 2026 at 4:26 PM Bohdan D. Marcus
<bohdandmarcus@gmail.com> wrote:
>
> Fix a block comment formatting warning reported by checkpatch.pl in atomisp_cmd.c to conform to the Linux kernel coding style.

Wrap the commit message at ~72 characters per line.

...

> -                       /* If the grid info in the argument differs from the current
> -                       grid info, we tell the caller to reset the grid size and
> -                       try again. */
> +                                               /*
> +                                                * If the grid info in the argument differs
> +                                                * from the current grid info, we tell the
> +                                                * caller to reset the grid size and try
> +                                                * again.
> +                                                */

Indentation is broken AFAICS.

>                         return -EAGAIN;
>                 }

Also, is this the only single issue of a kind in the whole (almost
100kLoC) driver?!

-- 
With Best Regards,
Andy Shevchenko