From: Shakeel Butt <shakeel.butt@linux.dev>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Brendan Jackman <jackmanb@google.com>, Zi Yan <ziy@nvidia.com>,
David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
Mike Rapoport <rppt@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] mm: fix reclaim storms in defrag_mode
Date: Wed, 1 Jul 2026 17:31:11 -0700 [thread overview]
Message-ID: <akWwg0irlanA_y1i@linux.dev> (raw)
In-Reply-To: <20260626182215.1107966-1-hannes@cmpxchg.org>
On Fri, Jun 26, 2026 at 02:21:16PM -0400, Johannes Weiner wrote:
> As we deployed vm.defrag_mode=1 into Meta production, some workloads
> regressed with recurring pressure spikes and swap storms (which in turn
> triggered userspace OOM rules on pressure and swap utilization levels).
>
> Tracing pinned this to non-movable
allocation?
> requests spinning and reclaiming
> unproductively when kswapd/kcompactd are overwhelmed. Direct reclaim
> predominantly frees up pages in movable blocks, but those requests
> cannot use that space under defrag_mode rules;
Do we have these rules documented somewhere?
> and it is unlikely to
> free up whole blocks incidentally for __rmqueue_claim() to work.
>
> This series fixes it by making non-movable requests participate in
> pageblock production in the allocator slowpath.
Sorry after reading above sentence I didn't get what those allocators will do
things differently after the series (I still have to go through the series).
>
> That requires some small-ish adjustments up front in the allocator and
> the compaction code: three prep patches and the fix last.
>
> The series has been in production against one of the affected workloads
> for two weeks and restores the OOM kill rate to !defrag_mode baseline.
>
> Based on mm-new (2026-06-22).
>
> include/linux/compaction.h | 3 +-
> mm/compaction.c | 68 ++++++++++++++++++++++++--------------------
> mm/internal.h | 7 +++++
> mm/page_alloc.c | 59 ++++++++++++++++++++++++++++++------
> 4 files changed, 98 insertions(+), 39 deletions(-)
>
prev parent reply other threads:[~2026-07-02 0:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-26 18:21 [PATCH 0/4] mm: fix reclaim storms in defrag_mode Johannes Weiner
2026-06-26 18:21 ` [PATCH 1/4] mm: page_alloc: __GFP_FS lockdep annotation for direct compaction Johannes Weiner
2026-07-01 13:45 ` Vlastimil Babka (SUSE)
2026-07-02 0:39 ` Shakeel Butt
2026-06-26 18:21 ` [PATCH 2/4] mm: compaction: support non-movable compaction for pageblock requests Johannes Weiner
2026-07-01 14:19 ` Vlastimil Babka (SUSE)
2026-07-01 15:28 ` Johannes Weiner
2026-07-01 18:14 ` Vlastimil Babka (SUSE)
2026-07-01 21:11 ` Johannes Weiner
2026-07-02 9:28 ` Vlastimil Babka (SUSE)
2026-07-02 1:47 ` Zi Yan
2026-06-26 18:21 ` [PATCH 3/4] mm: page_alloc: move capture_control to the page allocator Johannes Weiner
2026-07-01 18:02 ` Vlastimil Babka (SUSE)
2026-07-01 20:57 ` Johannes Weiner
2026-07-02 10:20 ` Vlastimil Babka (SUSE)
2026-06-26 18:21 ` [PATCH 4/4] mm: page_alloc: fix non-movable reclaim storm in defrag_mode Johannes Weiner
2026-06-26 18:29 ` Zi Yan
2026-06-26 18:43 ` Johannes Weiner
2026-07-01 18:06 ` Vlastimil Babka (SUSE)
2026-07-01 21:02 ` Johannes Weiner
2026-07-02 0:31 ` Shakeel Butt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akWwg0irlanA_y1i@linux.dev \
--to=shakeel.butt@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox