The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Johan Hovold <johan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 linux-usb@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] USB: gadget: fsl-udc: fix dev_printk() device
Date: Fri, 3 Jul 2026 00:38:18 +0200	[thread overview]
Message-ID: <akbmlZKNiF2z90F-@monoceros> (raw)
In-Reply-To: <20260702141536.90887-4-johan@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 754 bytes --]

Hello Johan,

On Thu, Jul 02, 2026 at 04:15:35PM +0200, Johan Hovold wrote:
> A change replacing custom printk() macros with dev_printk() incorrectly
> used the gadget struct device instead of the controller struct device
> (including for messages printed before the gadget device name has been
> initialised).
> 
> Switch to using the controller platform device with dev_printk() so that
> the controller device and driver names are included in log messages as
> expected.

I don't know about "expected", because before 6025f20f16c2 the affected
device wasn't included in the message at all. But I agree that using the
not yet initialized device isn't nice, so:

Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

Thanks
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2026-07-02 22:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-02 14:15 [PATCH 0/4] USB: gadget: fix device name leaks Johan Hovold
2026-07-02 14:15 ` [PATCH 1/4] USB: gadget: fsl-udc: fix device name leak on probe failure Johan Hovold
2026-07-02 14:15 ` [PATCH 2/4] USB: gadget: snps-udc: " Johan Hovold
2026-07-02 14:15 ` [PATCH 3/4] USB: gadget: fsl-udc: fix dev_printk() device Johan Hovold
2026-07-02 22:38   ` Uwe Kleine-König [this message]
2026-07-02 14:15 ` [PATCH 4/4] USB: gadget: fsl-udc: drop misleading unbind sanity check Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=akbmlZKNiF2z90F-@monoceros \
    --to=u.kleine-koenig@baylibre.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox