From: Guru Das Srinagesh <linux@gurudas.dev>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
"Danilo Krummrich" <dakr@kernel.org>,
"Abdiel Janulgue" <abdiel.janulgue@gmail.com>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Robin Murphy" <robin.murphy@arm.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Tamir Duberstein" <tamird@kernel.org>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Onur Özkan" <work@onurozkan.dev>,
"Drew Fustini" <fustini@kernel.org>,
"Guo Ren" <guoren@kernel.org>, "Fu Wei" <wefu@redhat.com>,
"Michal Wilczynski" <m.wilczynski@samsung.com>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Jens Axboe" <axboe@kernel.dk>,
"FUJITA Tomonori" <fujita.tomonori@gmail.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
driver-core@lists.linux.dev, linux-riscv@lists.infradead.org,
linux-pwm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-block@vger.kernel.org, netdev@vger.kernel.org,
nova-gpu@lists.linux.dev, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/7] rust: Use kernel style vertical imports in various drivers
Date: Sat, 4 Jul 2026 17:38:31 -0700 [thread overview]
Message-ID: <akmnh0AKFfu9-OYn@gurudas.dev> (raw)
In-Reply-To: <c89a1bc8-6cc1-4e16-ac95-add389e45a2b@lunn.ch>
On Mon, Jun 29, 2026 at 04:06:36PM +0200, Andrew Lunn wrote:
> On Sun, Jun 28, 2026 at 08:38:14PM -0700, Guru Das Srinagesh wrote:
> > Came across a recent commit bc58905eb07 ("samples: rust_misc_device: use
> > vertical import style") and found a few more locations that could
> > benefit from this cleanup. No functional changes.
> >
> > Signed-off-by: Guru Das Srinagesh <linux@gurudas.dev>
> > ---
> > Guru Das Srinagesh (7):
> > samples: rust_dma: use vertical import style
> > pwm: th1520: use vertical import style
> > cpufreq: rcpufreq_dt: use vertical import style
> > block: rnull: use vertical import style
> > net: phy: ax88796b: use vertical import style
> > net: phy: qt2025: use vertical import style
> > drm/nova: use vertical import style
>
> You have multiple subsystems here, so you need to split this patch
> setup, per subsystem, and submit them separately. Maintainers only
> accept patchsets for their own subsystems.
>
> For netdev, please take a read of:
>
> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
>
> You need to get the correct tree, and set the Subject: line correctly.
>
> Andrew
Hi Andrew,
Thanks for the feedback.
I was aware of the per-subsystem rule, but reasoned that since these changes are
purely about Rust import formatting coding style with no functional impact on any
subsystem, they might go through the rust-for-linux tree with acks from the
respective subsystem maintainers. The Rust coding style is independent of any
subsystem-specific guidelines.
Is that reasoning off-base, or is the right path to split these out per subsystem
regardless?
Miguel, could you please indicate if you have a preference here?
Thank you.
next prev parent reply other threads:[~2026-07-05 0:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 3:38 [PATCH 0/7] rust: Use kernel style vertical imports in various drivers Guru Das Srinagesh
2026-06-29 3:38 ` [PATCH 1/7] samples: rust_dma: use vertical import style Guru Das Srinagesh
2026-06-30 9:48 ` Danilo Krummrich
2026-07-05 1:15 ` Guru Das Srinagesh
2026-06-29 3:38 ` [PATCH 2/7] pwm: th1520: " Guru Das Srinagesh
2026-06-29 3:38 ` [PATCH 3/7] cpufreq: rcpufreq_dt: " Guru Das Srinagesh
2026-06-29 12:43 ` Zhongqiu Han
2026-06-30 8:35 ` Miguel Ojeda
2026-07-05 1:01 ` Guru Das Srinagesh
2026-07-05 12:12 ` Miguel Ojeda
2026-06-29 3:38 ` [PATCH 4/7] block: rnull: " Guru Das Srinagesh
2026-06-29 3:38 ` [PATCH 5/7] net: phy: ax88796b: " Guru Das Srinagesh
2026-06-29 3:38 ` [PATCH 6/7] net: phy: qt2025: " Guru Das Srinagesh
2026-06-29 3:38 ` [PATCH 7/7] drm/nova: " Guru Das Srinagesh
2026-06-29 14:06 ` [PATCH 0/7] rust: Use kernel style vertical imports in various drivers Andrew Lunn
2026-07-05 0:38 ` Guru Das Srinagesh [this message]
2026-07-05 12:08 ` Gary Guo
2026-07-05 12:22 ` Miguel Ojeda
2026-07-05 15:03 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akmnh0AKFfu9-OYn@gurudas.dev \
--to=linux@gurudas.dev \
--cc=a.hindborg@kernel.org \
--cc=abdiel.janulgue@gmail.com \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=andrew@lunn.ch \
--cc=axboe@kernel.dk \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=driver-core@lists.linux.dev \
--cc=edumazet@google.com \
--cc=fujita.tomonori@gmail.com \
--cc=fustini@kernel.org \
--cc=gary@garyguo.net \
--cc=guoren@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=lossin@kernel.org \
--cc=m.wilczynski@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=nova-gpu@lists.linux.dev \
--cc=ojeda@kernel.org \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=ukleinek@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=wefu@redhat.com \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox