[PATCH] apparmor: use SEND_SIG_NOINFO instead of NULL in aa_audit()

[PATCH] apparmor: use SEND_SIG_NOINFO instead of NULL in aa_audit()

[Oleg Nesterov]

SEND_SIG_NOINFO is defined as ((struct kernel_siginfo *) 0), so passing
NULL works, but:

- this works "by accident" and looks as if the caller doesn't understand
  the signal sending API.

- more importantly, this hides the usage of SEND_SIG_NOINFO from grep,
  and this is really bad.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
 security/apparmor/audit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/apparmor/audit.c b/security/apparmor/audit.c
index 4a60b6fda75f..15e42e96b163 100644
--- a/security/apparmor/audit.c
+++ b/security/apparmor/audit.c
@@ -192,7 +192,7 @@ int aa_audit(int type, struct aa_profile *profile,
 	aa_audit_msg(type, ad, cb);
 
 	if (ad->type == AUDIT_APPARMOR_KILL)
-		(void)send_sig_info(profile->signal, NULL,
+		send_sig_info(profile->signal, SEND_SIG_NOINFO,
 			ad->common.type == LSM_AUDIT_DATA_TASK &&
 			ad->common.u.tsk ? ad->common.u.tsk : current);
 
-- 
2.52.0

Re: [PATCH] apparmor: use SEND_SIG_NOINFO instead of NULL in aa_audit()

[Bradley Morgan]

> SEND_SIG_NOINFO is defined as ((struct kernel_siginfo *) 0), so passing
> NULL works, but:
>
> - this works "by accident" and looks as if the caller doesn't understand
>   the signal sending API.
>
> - more importantly, this hides the usage of SEND_SIG_NOINFO from grep,
>   and this is really bad.
- also drop the now redundant (void)
>
Reviewed-by: Bradley Morgan <include@grrlz.net>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> ---
>  security/apparmor/audit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/apparmor/audit.c b/security/apparmor/audit.c
> index 4a60b6fda75f..15e42e96b163 100644
> --- a/security/apparmor/audit.c
> +++ b/security/apparmor/audit.c
> @@ -192,7 +192,7 @@ int aa_audit(int type, struct aa_profile *profile,
>  	aa_audit_msg(type, ad, cb);
>  
>  	if (ad->type == AUDIT_APPARMOR_KILL)
> -		(void)send_sig_info(profile->signal, NULL,
> +		send_sig_info(profile->signal, SEND_SIG_NOINFO,
>  			ad->common.type == LSM_AUDIT_DATA_TASK &&
>  			ad->common.u.tsk ? ad->common.u.tsk : current);
>  
> -- 
> 2.52.0


Also, feel free to CC me in signal patches, so I can review, from you
or from others.
Thanks!

Re: [PATCH] apparmor: use SEND_SIG_NOINFO instead of NULL in aa_audit()

[Oleg Nesterov]

On 07/05, Bradley Morgan wrote:
>
> > SEND_SIG_NOINFO is defined as ((struct kernel_siginfo *) 0), so passing
> > NULL works, but:
> >
> > - this works "by accident" and looks as if the caller doesn't understand
> >   the signal sending API.
> >
> > - more importantly, this hides the usage of SEND_SIG_NOINFO from grep,
> >   and this is really bad.
> - also drop the now redundant (void)

Yes, but the "void" cast was never necessary, I guess.

and just in case... To me the usage of SEND_SIG_NOINFO here doesn't look right with
or without this change. Perhaps I am wrong, but please lets not discuss this right
now, this connects to other cleanups I have in mind.

The purpose of this change is to make aa_audit() grep-friendly wrt SEND_SIG_NOINFO.
And because send_sig_info(NULL) looks "just wrong" to me, no matter what.

> Reviewed-by: Bradley Morgan <include@grrlz.net>

Thanks,

> Also, feel free to CC me in signal patches, so I can review, from you
> or from others.

OK, will do.

Oleg.

Re: [PATCH] apparmor: use SEND_SIG_NOINFO instead of NULL in aa_audit()

[Bradley Morgan]

On July 5, 2026 7:48:04 PM GMT+01:00, Oleg Nesterov <oleg@redhat.com>
wrote:
>On 07/05, Bradley Morgan wrote:
>>
>> > SEND_SIG_NOINFO is defined as ((struct kernel_siginfo *) 0), so
>passing
>> > NULL works, but:
>> >
>> > - this works "by accident" and looks as if the caller doesn't
>understand
>> >   the signal sending API.
>> >
>> > - more importantly, this hides the usage of SEND_SIG_NOINFO from grep,
>> >   and this is really bad.
>> - also drop the now redundant (void)
>
>Yes, but the "void" cast was never necessary, I guess.
>
>and just in case... To me the usage of SEND_SIG_NOINFO here doesn't look
>right with
>or without this change. Perhaps I am wrong, but please lets not discuss
>this right
>now, this connects to other cleanups I have in mind.
>
>The purpose of this change is to make aa_audit() grep-friendly wrt
>SEND_SIG_NOINFO.
>And because send_sig_info(NULL) looks "just wrong" to me, no matter what.

No need, just a teeny tiny description nit.

>> Reviewed-by: Bradley Morgan <include@grrlz.net>
>
>Thanks,
>
>> Also, feel free to CC me in signal patches, so I can review, from you
>> or from others.
>
>OK, will do.
>
>Oleg.
>
>

Thanks!