Re: [PATCH v3 6/8] riscv: Enable resctrl filesystem for Ssqosid

[Drew Fustini <fustini@kernel.org>]

On Sun, Jun 28, 2026 at 09:30:07PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] RISCV_ISA_SSQOSID unconditionally selects the user-visible menuconfig RISCV_CBQRI, defeating its prompt and violating Kconfig best practices.
> --
> 
> commit 6a7bfcfac7becb358efe0bde0c988634f28e5326
> Author: Drew Fustini <fustini@kernel.org>
> 
> riscv: Enable resctrl filesystem for Ssqosid
> 
> This commit enables the resctrl filesystem for the RISC-V Ssqosid extension.
> It modifies the RISCV_ISA_SSQOSID config to select ARCH_HAS_CPU_RESCTRL and
> RISCV_CBQRI.
> 
> > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> > index ee586925f9722..9c28bcbc29dc9 100644
> > --- a/arch/riscv/Kconfig
> > +++ b/arch/riscv/Kconfig
> > @@ -594,6 +594,8 @@ config RISCV_ISA_SSQOSID
> >  	bool "Ssqosid extension support for supervisor mode Quality of Service ID"
> >  	depends on 64BIT
> >  	default n
> > +	select ARCH_HAS_CPU_RESCTRL
> > +	select RISCV_CBQRI
> 
> [Severity: Medium]
> Is it intentional to use select on RISCV_CBQRI here?
> 
> RISCV_CBQRI appears to be defined as a user-visible menuconfig:
> 
> drivers/resctrl/Kconfig:
> menuconfig RISCV_CBQRI
> 	bool "RISC-V CBQRI support"
> 	depends on RISCV && RISCV_ISA_SSQOSID
> 
> Using select on a user-visible symbol forces it on and overrides the prompt,
> which can create a confusing configuration experience where the option is
> visible but cannot be toggled.
> 
> Could this be addressed by either using "depends on" instead of select,
> or by making RISCV_CBQRI a hidden symbol without a prompt?

I'll make RISCV_CBQRI user-selectable in the next revision: drop the select
from RISCV_ISA_SSQOSID, make RISCV_CBQRI depend on RISCV_ISA_SSQOSID with
default y, and move select ARCH_HAS_CPU_RESCTRL onto it.

-Drew