* [PATCH] clk: ti: adpll: unregister OF clock provider on remove
@ 2026-06-26 9:41 Myeonghun Pak
2026-07-06 17:16 ` Brian Masney
0 siblings, 1 reply; 2+ messages in thread
From: Myeonghun Pak @ 2026-06-26 9:41 UTC (permalink / raw)
To: Tero Kristo, Michael Turquette, Stephen Boyd
Cc: linux-omap, linux-clk, linux-kernel, Myeonghun Pak, Ijae Kim
ti_adpll_probe() registers the driver's onecell clock provider with
of_clk_add_provider(). The remove path only frees the clock resources,
leaving the provider registered after the backing data has been torn
down.
Unregister the OF clock provider before freeing the ADPLL resources so
the provider no longer points at released driver data after device
removal.
Fixes: 21330497f303 ("clk: ti: Add support for dm814x ADPLL")
Co-developed-by: Ijae Kim <ae878000@gmail.com>
Signed-off-by: Ijae Kim <ae878000@gmail.com>
Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
---
drivers/clk/ti/adpll.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/ti/adpll.c b/drivers/clk/ti/adpll.c
index e305fcb..0c22e33 100644
--- a/drivers/clk/ti/adpll.c
+++ b/drivers/clk/ti/adpll.c
@@ -925,6 +925,7 @@ static void ti_adpll_remove(struct platform_device *pdev)
{
struct ti_adpll_data *d = dev_get_drvdata(&pdev->dev);
+ of_clk_del_provider(d->np);
ti_adpll_free_resources(d);
}
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] clk: ti: adpll: unregister OF clock provider on remove
2026-06-26 9:41 [PATCH] clk: ti: adpll: unregister OF clock provider on remove Myeonghun Pak
@ 2026-07-06 17:16 ` Brian Masney
0 siblings, 0 replies; 2+ messages in thread
From: Brian Masney @ 2026-07-06 17:16 UTC (permalink / raw)
To: Myeonghun Pak
Cc: Tero Kristo, Michael Turquette, Stephen Boyd, linux-omap,
linux-clk, linux-kernel, Ijae Kim
On Fri, Jun 26, 2026 at 06:41:26PM +0900, Myeonghun Pak wrote:
> ti_adpll_probe() registers the driver's onecell clock provider with
> of_clk_add_provider(). The remove path only frees the clock resources,
> leaving the provider registered after the backing data has been torn
> down.
>
> Unregister the OF clock provider before freeing the ADPLL resources so
> the provider no longer points at released driver data after device
> removal.
>
> Fixes: 21330497f303 ("clk: ti: Add support for dm814x ADPLL")
> Co-developed-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
Reviewed-by: Brian Masney <bmasney@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-06 17:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-26 9:41 [PATCH] clk: ti: adpll: unregister OF clock provider on remove Myeonghun Pak
2026-07-06 17:16 ` Brian Masney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox