From: Christoph Hellwig <hch@infradead.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, stable@vger.kernel.org
Subject: Re: [PATCH] fscrypt: Avoid dynamic allocation in fscrypt_get_devices()
Date: Mon, 20 Jul 2026 02:23:34 -0700 [thread overview]
Message-ID: <al3pFrj8eAV0MSSO@infradead.org> (raw)
In-Reply-To: <20260719055602.78828-1-ebiggers@kernel.org>
On Sat, Jul 18, 2026 at 10:56:02PM -0700, Eric Biggers wrote:
> For now, let's fix this in the straightforward and easily-backportable
> way by switching to an on-stack array. Currently the fscrypt
> multi-device functionality is used only by f2fs, which has a hardcoded
> limit of 8 block devices. An on-stack array works fine for that.
Looks fine as a quick fix:
Reviewed-by: Christoph Hellwig <hch@lst.de>
> (Of course, this solution won't scale up to large number of block
> devices. For that we'd need a different solution, like moving the block
> device iteration into the filesystem.
I'd love to see this happen rather sooner than later, as that's a much
better architecture.
next prev parent reply other threads:[~2026-07-20 9:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-19 5:56 [PATCH] fscrypt: Avoid dynamic allocation in fscrypt_get_devices() Eric Biggers
2026-07-20 9:23 ` Christoph Hellwig [this message]
2026-07-20 17:45 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=al3pFrj8eAV0MSSO@infradead.org \
--to=hch@infradead.org \
--cc=ebiggers@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox