From: Oleg Nesterov <oleg@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "Cen Zhang (Microsoft)" <blbllhy@gmail.com>,
brauner@kernel.org, akpm@linux-foundation.org, jack@suse.cz,
avagin@gmail.com, ptikhomirov@virtuozzo.com, mjguzik@gmail.com,
include@grrlz.net, legion@kernel.org,
linux-kernel@vger.kernel.org,
AutonomousCodeSecurity@microsoft.com,
tgopinath@linux.microsoft.com, kys@microsoft.com
Subject: Re: [PATCH v3 1/2] pid: deinline kill_cad_pid
Date: Mon, 20 Jul 2026 15:45:03 +0200 [thread overview]
Message-ID: <al4mX4TFdivlDW1F@redhat.com> (raw)
In-Reply-To: <87tsptu7b7.fsf@email.froward.int.ebiederm.org>
On 07/20, Eric W. Biederman wrote:
>
> "Cen Zhang (Microsoft)" <blbllhy@gmail.com> writes:
>
> > Move kill_cad_pid() out of the header without changing behavior. This
> > prepares for taking a reference to cad_pid under RCU in the following
> > fix.
>
> nit: If you are going to uninline kill_cad_pid should be placed in
> signal.c not in pid.c
>
> That is where everything else that sends signals lives.
Agreed, but...
I had a private discussion with Alexey. And he pointed out that if
we move kill_cad_pid() to reboot.c we are almost ready to unexport
cad_pid and make it static.
The only problem is kernel_init_freeable(). but I guess we can shift
the cad_pid initialization to reboot_ksysfs_init().
Anyway, this needs another patch. So I agree with signal.c in 1/2.
Oleg.
next prev parent reply other threads:[~2026-07-20 13:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-19 15:58 [PATCH v3 1/2] pid: deinline kill_cad_pid Cen Zhang (Microsoft)
2026-07-19 15:58 ` [PATCH v3 2/2] pid: fix cad_pid use-after-free race Cen Zhang (Microsoft)
2026-07-20 10:09 ` Pavel Tikhomirov
2026-07-19 16:20 ` [PATCH v3 1/2] pid: deinline kill_cad_pid Oleg Nesterov
2026-07-19 16:26 ` Cen Zhang (Microsoft)
2026-07-20 9:56 ` Pavel Tikhomirov
2026-07-20 13:19 ` Eric W. Biederman
2026-07-20 13:45 ` Oleg Nesterov [this message]
2026-07-20 14:01 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=al4mX4TFdivlDW1F@redhat.com \
--to=oleg@redhat.com \
--cc=AutonomousCodeSecurity@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@gmail.com \
--cc=blbllhy@gmail.com \
--cc=brauner@kernel.org \
--cc=ebiederm@xmission.com \
--cc=include@grrlz.net \
--cc=jack@suse.cz \
--cc=kys@microsoft.com \
--cc=legion@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjguzik@gmail.com \
--cc=ptikhomirov@virtuozzo.com \
--cc=tgopinath@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox