* [PATCH] sched_ext: Fix typo in scx_bpf_dsq_insert() comment
@ 2026-07-09 8:02 luoliang
2026-07-09 20:23 ` Andrea Righi
2026-07-09 21:40 ` Tejun Heo
0 siblings, 2 replies; 3+ messages in thread
From: luoliang @ 2026-07-09 8:02 UTC (permalink / raw)
To: Tejun Heo; +Cc: David Vernet, Andrea Righi, sched-ext, linux-kernel, Liang Luo
From: Liang Luo <luoliang@kylinos.cn>
The comment for scx_bpf_dsq_insert() references "@dsp_id" in the
description body, but the parameter is named "@dsq_id" in both the
parameter list and the function signature.
Signed-off-by: Liang Luo <luoliang@kylinos.cn>
---
kernel/sched/ext/ext.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/ext/ext.c b/kernel/sched/ext/ext.c
index 691d53fe0f64..cbfa23d71e68 100644
--- a/kernel/sched/ext/ext.c
+++ b/kernel/sched/ext/ext.c
@@ -8572,7 +8572,7 @@ __bpf_kfunc_start_defs();
* When called from ops.select_cpu() or ops.enqueue(), it's for direct dispatch
* and @p must match the task being enqueued.
*
- * When called from ops.select_cpu(), @enq_flags and @dsp_id are stored, and @p
+ * When called from ops.select_cpu(), @enq_flags and @dsq_id are stored, and @p
* will be directly inserted into the corresponding dispatch queue after
* ops.select_cpu() returns. If @p is inserted into SCX_DSQ_LOCAL, it will be
* inserted into the local DSQ of the CPU returned by ops.select_cpu().
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sched_ext: Fix typo in scx_bpf_dsq_insert() comment
2026-07-09 8:02 [PATCH] sched_ext: Fix typo in scx_bpf_dsq_insert() comment luoliang
@ 2026-07-09 20:23 ` Andrea Righi
2026-07-09 21:40 ` Tejun Heo
1 sibling, 0 replies; 3+ messages in thread
From: Andrea Righi @ 2026-07-09 20:23 UTC (permalink / raw)
To: luoliang; +Cc: Tejun Heo, David Vernet, sched-ext, linux-kernel
Hi Liang,
On Thu, Jul 09, 2026 at 04:02:05PM +0800, luoliang@kylinos.cn wrote:
> From: Liang Luo <luoliang@kylinos.cn>
>
> The comment for scx_bpf_dsq_insert() references "@dsp_id" in the
> description body, but the parameter is named "@dsq_id" in both the
> parameter list and the function signature.
>
> Signed-off-by: Liang Luo <luoliang@kylinos.cn>
Yep, that's a typo.
Acked-by: Andrea Righi <arighi@nvidia.com>
Thanks,
-Andrea
> ---
> kernel/sched/ext/ext.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/ext/ext.c b/kernel/sched/ext/ext.c
> index 691d53fe0f64..cbfa23d71e68 100644
> --- a/kernel/sched/ext/ext.c
> +++ b/kernel/sched/ext/ext.c
> @@ -8572,7 +8572,7 @@ __bpf_kfunc_start_defs();
> * When called from ops.select_cpu() or ops.enqueue(), it's for direct dispatch
> * and @p must match the task being enqueued.
> *
> - * When called from ops.select_cpu(), @enq_flags and @dsp_id are stored, and @p
> + * When called from ops.select_cpu(), @enq_flags and @dsq_id are stored, and @p
> * will be directly inserted into the corresponding dispatch queue after
> * ops.select_cpu() returns. If @p is inserted into SCX_DSQ_LOCAL, it will be
> * inserted into the local DSQ of the CPU returned by ops.select_cpu().
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sched_ext: Fix typo in scx_bpf_dsq_insert() comment
2026-07-09 8:02 [PATCH] sched_ext: Fix typo in scx_bpf_dsq_insert() comment luoliang
2026-07-09 20:23 ` Andrea Righi
@ 2026-07-09 21:40 ` Tejun Heo
1 sibling, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2026-07-09 21:40 UTC (permalink / raw)
To: Liang Luo
Cc: David Vernet, Andrea Righi, sched-ext, linux-kernel,
Emil Tsalapatis
Applied to sched_ext/for-7.3.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-09 21:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-09 8:02 [PATCH] sched_ext: Fix typo in scx_bpf_dsq_insert() comment luoliang
2026-07-09 20:23 ` Andrea Righi
2026-07-09 21:40 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox