Re: [PATCH 5/7] dmaengine: dw-edma-pcie: Drop redundant pci_free_irq_vectors()

[Frank Li <Frank.li@oss.nxp.com>]

On Fri, Jul 10, 2026 at 05:09:01PM +0900, Koichiro Den wrote:
> dw_edma_pcie enables the PCI device with pcim_enable_device(), so IRQ
> vectors allocated by pci_alloc_irq_vectors() are released by
> pcim_msi_release() on device release. The driver should not call
> pci_free_irq_vectors() manually.
>
> Drop the redundant remove-time cleanup and rely on the managed PCI
> device lifetime instead, as documented by commit 03e4905402ae ("PCI/MSI:
> Clarify pci_free_irq_vectors() usage for managed devices").
>
> Signed-off-by: Koichiro Den <den@valinux.co.jp>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> Changes in v2:
>   - New patch in v2, posted as part of this preparation series.
>
>  drivers/dma/dw-edma/dw-edma-pcie.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
> index 791c46e8ae4c..5e81a433a957 100644
> --- a/drivers/dma/dw-edma/dw-edma-pcie.c
> +++ b/drivers/dma/dw-edma/dw-edma-pcie.c
> @@ -555,9 +555,6 @@ static void dw_edma_pcie_remove(struct pci_dev *pdev)
>  	err = dw_edma_remove(chip);
>  	if (err)
>  		pci_warn(pdev, "can't remove device properly: %d\n", err);
> -
> -	/* Freeing IRQs */
> -	pci_free_irq_vectors(pdev);
>  }
>
>  static const struct pci_device_id dw_edma_pcie_id_table[] = {
> --
> 2.51.0
>