From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
Russ Weight <russ.weight@linux.dev>,
driver-core@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] firmware_loader: builtin: fail build on empty firmware
Date: Sat, 11 Jul 2026 17:23:55 -0700 [thread overview]
Message-ID: <alLee0s4gtCM7dVj@google.com> (raw)
In-Reply-To: <DJW5EBHLCXO4.PFQOK4M2ZZ48@kernel.org>
On Sun, Jul 12, 2026 at 01:58:26AM +0200, Danilo Krummrich wrote:
> On Sun Apr 26, 2026 at 6:30 AM CEST, Dmitry Torokhov wrote:
> > + if [ ! -s "$(fwdir)/$(FWNAME)" ]; then \
> > + echo "error: empty firmware: $(fwdir)/$(FWNAME)" >&2 ;\
> > + exit ;\
>
> Shouldn't this be 'exit 1' to actually fail the build?
Yes, you are absolutely right. Do you want me to resend or you can fix
it up on your end?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2026-07-12 0:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-26 4:30 [PATCH 1/2] firmware_loader: builtin: ignore 0-size firmware Dmitry Torokhov
2026-04-26 4:30 ` [PATCH 2/2] firmware_loader: builtin: fail build on empty firmware Dmitry Torokhov
2026-07-11 23:58 ` Danilo Krummrich
2026-07-12 0:23 ` Dmitry Torokhov [this message]
2026-07-11 22:11 ` [PATCH 1/2] firmware_loader: builtin: ignore 0-size firmware Dmitry Torokhov
2026-07-11 23:57 ` Danilo Krummrich
2026-07-11 23:57 ` (subset) " Danilo Krummrich
2026-07-12 0:29 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alLee0s4gtCM7dVj@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=dakr@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=russ.weight@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox