From: Thorsten Blum <thorsten.blum@linux.dev>
To: Ritesh Harjani <ritesh.list@gmail.com>
Cc: Geoff Levand <geoff@infradead.org>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
Paul Mackerras <paulus@ozlabs.org>,
MOKUNO Masakazu <mokuno@sm.sony.co.jp>,
stable@vger.kernel.org,
Geoff Levand <geoffrey.levand@am.sony.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/ps3: Fix map failure path in dma_ioc0_map_pages()
Date: Mon, 13 Jul 2026 17:08:44 +0200 [thread overview]
Message-ID: <alT_fEu9AtQT9PxU@linux.dev> (raw)
In-Reply-To: <ik6jukrj.ritesh.list@gmail.com>
On Mon, Jul 13, 2026 at 06:08:56PM +0530, Ritesh Harjani wrote:
> Thorsten Blum <thorsten.blum@linux.dev> writes:
>
> > If lv1_put_iopte() fails in dma_ioc0_map_pages(), the error path
> > decrements iopage but keeps using the failed mapping's offset. As a
> > result, it repeatedly tries to invalidate the failed IOPTE slot and
> > leaves the already installed IOPTEs valid.
> >
> > Recompute offset and invalidate the installed IOPTEs instead.
> >
>
> Nice catch! I wonder how did you catch this?
> Do you have ps3 console where you somehow ran into this ;)
> Or was it a manual inspection?
I do have a PS3 somewhere, but I stumbled upon this while reading and
trying to understand the code.
> I wonder whether PS3 consoles are still being used?
Not sure.
> > Fixes: 6bb5cf102541 ("[POWERPC] PS3: System-bus rework")
>
> Looks like this was from 2007.
>
> However, the change looks good to me. So:
> Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Thanks,
Thorsten
next prev parent reply other threads:[~2026-07-13 15:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-11 13:09 [PATCH] powerpc/ps3: Fix map failure path in dma_ioc0_map_pages() Thorsten Blum
2026-07-13 7:21 ` Geert Uytterhoeven
2026-07-13 12:38 ` Ritesh Harjani
2026-07-13 15:08 ` Thorsten Blum [this message]
2026-07-13 16:19 ` Florian Fuchs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alT_fEu9AtQT9PxU@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=chleroy@kernel.org \
--cc=geoff@infradead.org \
--cc=geoffrey.levand@am.sony.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mokuno@sm.sony.co.jp \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@ozlabs.org \
--cc=ritesh.list@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox