[PATCH v3 1/1] MIPS: Alchemy: Remove unused forward declaration

[PATCH v3 1/1] MIPS: Alchemy: Remove unused forward declaration

[Andy Shevchenko]

The 'struct gpio' is not used in the code, remove unneeded forward declaration.
This seems to be a leftover for a 5 years.

Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---

Cc: Bartosz Golaszewski <brgl@kernel.org>

This patch is floating around for more than a year without anybody
taking it! Please, please, do something about this. Since it has
an ack by MIPS maintainer, Bart, can you just pick this up?

 arch/mips/include/asm/mach-au1x00/gpio-au1300.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/mips/include/asm/mach-au1x00/gpio-au1300.h b/arch/mips/include/asm/mach-au1x00/gpio-au1300.h
index 912534ecb1a4..c92d3c2a5ef8 100644
--- a/arch/mips/include/asm/mach-au1x00/gpio-au1300.h
+++ b/arch/mips/include/asm/mach-au1x00/gpio-au1300.h
@@ -12,7 +12,6 @@
 #include <asm/io.h>
 #include <asm/mach-au1x00/au1000.h>
 
-struct gpio;
 struct gpio_chip;
 struct software_node;
 
-- 
2.50.1

Re: [PATCH v3 1/1] MIPS: Alchemy: Remove unused forward declaration

[Bartosz Golaszewski]

On Wed, 15 Jul 2026 17:03:48 +0200, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> said:
> The 'struct gpio' is not used in the code, remove unneeded forward declaration.
> This seems to be a leftover for a 5 years.
>
> Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>
> Cc: Bartosz Golaszewski <brgl@kernel.org>
>
> This patch is floating around for more than a year without anybody
> taking it! Please, please, do something about this. Since it has
> an ack by MIPS maintainer, Bart, can you just pick this up?
>
>  arch/mips/include/asm/mach-au1x00/gpio-au1300.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/mips/include/asm/mach-au1x00/gpio-au1300.h b/arch/mips/include/asm/mach-au1x00/gpio-au1300.h
> index 912534ecb1a4..c92d3c2a5ef8 100644
> --- a/arch/mips/include/asm/mach-au1x00/gpio-au1300.h
> +++ b/arch/mips/include/asm/mach-au1x00/gpio-au1300.h
> @@ -12,7 +12,6 @@
>  #include <asm/io.h>
>  #include <asm/mach-au1x00/au1000.h>
>
> -struct gpio;
>  struct gpio_chip;
>  struct software_node;
>
> --
> 2.50.1
>
>

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

Re: [PATCH v3 1/1] MIPS: Alchemy: Remove unused forward declaration

[Andy Shevchenko]

On Wed, Jul 15, 2026 at 08:08:00AM -0700, Bartosz Golaszewski wrote:
> On Wed, 15 Jul 2026 17:03:48 +0200, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> said:

...

> > Cc: Bartosz Golaszewski <brgl@kernel.org>
> >
> > This patch is floating around for more than a year without anybody
> > taking it! Please, please, do something about this. Since it has
> > an ack by MIPS maintainer, Bart, can you just pick this up?

> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

Thanks, and sorry for the noise, I was cleaning an old branch and actually this
had been applied already. Sorry again, I need some vacation (which will happen
in a week).

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v3 1/1] MIPS: Alchemy: Remove unused forward declaration

[Thomas Bogendoerfer]

On Wed, Jul 15, 2026 at 06:19:37PM +0300, Andy Shevchenko wrote:
> On Wed, Jul 15, 2026 at 08:08:00AM -0700, Bartosz Golaszewski wrote:
> > On Wed, 15 Jul 2026 17:03:48 +0200, Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> said:
> 
> ...
> 
> > > Cc: Bartosz Golaszewski <brgl@kernel.org>
> > >
> > > This patch is floating around for more than a year without anybody
> > > taking it! Please, please, do something about this. Since it has
> > > an ack by MIPS maintainer, Bart, can you just pick this up?
> 
> > Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> 
> Thanks, and sorry for the noise, I was cleaning an old branch and actually this
> had been applied already. Sorry again, I need some vacation (which will happen
> in a week).

d1d0aa620a0f MIPS: Alchemy: Remove unused forward declaration

I took it last merge window, or do I miss something ?

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

Re: [PATCH v3 1/1] MIPS: Alchemy: Remove unused forward declaration

[Andy Shevchenko]

On Wed, Jul 15, 2026 at 05:44:44PM +0200, Thomas Bogendoerfer wrote:
> On Wed, Jul 15, 2026 at 06:19:37PM +0300, Andy Shevchenko wrote:
> > On Wed, Jul 15, 2026 at 08:08:00AM -0700, Bartosz Golaszewski wrote:
> > > On Wed, 15 Jul 2026 17:03:48 +0200, Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> said:

...

> > > > Cc: Bartosz Golaszewski <brgl@kernel.org>
> > > >
> > > > This patch is floating around for more than a year without anybody
> > > > taking it! Please, please, do something about this. Since it has
> > > > an ack by MIPS maintainer, Bart, can you just pick this up?
> > 
> > > Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> > 
> > Thanks, and sorry for the noise, I was cleaning an old branch and actually this
> > had been applied already. Sorry again, I need some vacation (which will happen
> > in a week).
> 
> d1d0aa620a0f MIPS: Alchemy: Remove unused forward declaration
> 
> I took it last merge window, or do I miss something ?

Yes, and that's why I am sorry!

-- 
With Best Regards,
Andy Shevchenko