From: atull <atull@opensource.altera.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Moritz Fischer <moritz.fischer@ettus.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA
Date: Mon, 6 Jun 2016 13:02:55 -0500 [thread overview]
Message-ID: <alpine.DEB.2.02.1606061302370.4161@linuxheads99> (raw)
In-Reply-To: <1465119597-5461-1-git-send-email-geert@linux-m68k.org>
On Sun, 5 Jun 2016, Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> ERROR: "bad_dma_ops" [drivers/fpga/zynq-fpga.ko] undefined!
>
> Add a dependency on HAS_DMA to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Reviewed-by: Moritz Fischer <moritz.fischer@ettus.com>
> ---
> v2:
> - Add Reviewed-by,
> - Updated error message for recent kernels,
> - Submit to Greg, as requested by Alan.
Hi Geert,
Thank you!
Alan
> ---
> drivers/fpga/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index c9b9fdf6cfbbeb6d..d61410299ec0cf80 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA
>
> config FPGA_MGR_ZYNQ_FPGA
> tristate "Xilinx Zynq FPGA"
> + depends on HAS_DMA
> help
> FPGA manager driver support for Xilinx Zynq FPGAs.
>
> --
> 1.9.1
>
>
next prev parent reply other threads:[~2016-06-06 18:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-05 9:39 [PATCH v2] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA Geert Uytterhoeven
2016-06-06 18:02 ` atull [this message]
2016-06-06 20:37 ` Moritz Fischer
2016-06-07 14:11 ` atull
2016-06-07 14:17 ` atull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1606061302370.4161@linuxheads99 \
--to=atull@opensource.altera.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moritz.fischer@ettus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox