* [PATCH v2] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA
@ 2016-06-05 9:39 Geert Uytterhoeven
2016-06-06 18:02 ` atull
2016-06-07 14:17 ` atull
0 siblings, 2 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2016-06-05 9:39 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Alan Tull, Moritz Fischer, linux-kernel, Geert Uytterhoeven
If NO_DMA=y:
ERROR: "bad_dma_ops" [drivers/fpga/zynq-fpga.ko] undefined!
Add a dependency on HAS_DMA to fix this.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Moritz Fischer <moritz.fischer@ettus.com>
---
v2:
- Add Reviewed-by,
- Updated error message for recent kernels,
- Submit to Greg, as requested by Alan.
---
drivers/fpga/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
index c9b9fdf6cfbbeb6d..d61410299ec0cf80 100644
--- a/drivers/fpga/Kconfig
+++ b/drivers/fpga/Kconfig
@@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA
config FPGA_MGR_ZYNQ_FPGA
tristate "Xilinx Zynq FPGA"
+ depends on HAS_DMA
help
FPGA manager driver support for Xilinx Zynq FPGAs.
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA
2016-06-05 9:39 [PATCH v2] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA Geert Uytterhoeven
@ 2016-06-06 18:02 ` atull
2016-06-06 20:37 ` Moritz Fischer
2016-06-07 14:17 ` atull
1 sibling, 1 reply; 5+ messages in thread
From: atull @ 2016-06-06 18:02 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Greg Kroah-Hartman, Moritz Fischer, linux-kernel
On Sun, 5 Jun 2016, Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> ERROR: "bad_dma_ops" [drivers/fpga/zynq-fpga.ko] undefined!
>
> Add a dependency on HAS_DMA to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Reviewed-by: Moritz Fischer <moritz.fischer@ettus.com>
> ---
> v2:
> - Add Reviewed-by,
> - Updated error message for recent kernels,
> - Submit to Greg, as requested by Alan.
Hi Geert,
Thank you!
Alan
> ---
> drivers/fpga/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index c9b9fdf6cfbbeb6d..d61410299ec0cf80 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA
>
> config FPGA_MGR_ZYNQ_FPGA
> tristate "Xilinx Zynq FPGA"
> + depends on HAS_DMA
> help
> FPGA manager driver support for Xilinx Zynq FPGAs.
>
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA
2016-06-06 18:02 ` atull
@ 2016-06-06 20:37 ` Moritz Fischer
2016-06-07 14:11 ` atull
0 siblings, 1 reply; 5+ messages in thread
From: Moritz Fischer @ 2016-06-06 20:37 UTC (permalink / raw)
To: atull; +Cc: Geert Uytterhoeven, Greg Kroah-Hartman, Linux Kernel Mailing List
Hi Alan, Geert
On Mon, Jun 6, 2016 at 11:02 AM, atull <atull@opensource.altera.com> wrote:
> On Sun, 5 Jun 2016, Geert Uytterhoeven wrote:
>
>> If NO_DMA=y:
>>
>> ERROR: "bad_dma_ops" [drivers/fpga/zynq-fpga.ko] undefined!
>>
>> Add a dependency on HAS_DMA to fix this.
>>
>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> Reviewed-by: Moritz Fischer <moritz.fischer@ettus.com>
>> ---
>> v2:
>> - Add Reviewed-by,
>> - Updated error message for recent kernels,
>> - Submit to Greg, as requested by Alan.
>
> Hi Geert,
>
> Thank you!
We should probably pick this one over Sudip's duplicate?
Cheers,
Moritz
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA
2016-06-06 20:37 ` Moritz Fischer
@ 2016-06-07 14:11 ` atull
0 siblings, 0 replies; 5+ messages in thread
From: atull @ 2016-06-07 14:11 UTC (permalink / raw)
To: Moritz Fischer
Cc: Geert Uytterhoeven, Greg Kroah-Hartman, Linux Kernel Mailing List
On Mon, 6 Jun 2016, Moritz Fischer wrote:
> Hi Alan, Geert
>
> On Mon, Jun 6, 2016 at 11:02 AM, atull <atull@opensource.altera.com> wrote:
> > On Sun, 5 Jun 2016, Geert Uytterhoeven wrote:
> >
> >> If NO_DMA=y:
> >>
> >> ERROR: "bad_dma_ops" [drivers/fpga/zynq-fpga.ko] undefined!
> >>
> >> Add a dependency on HAS_DMA to fix this.
> >>
> >> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >> Reviewed-by: Moritz Fischer <moritz.fischer@ettus.com>
> >> ---
> >> v2:
> >> - Add Reviewed-by,
> >> - Updated error message for recent kernels,
> >> - Submit to Greg, as requested by Alan.
> >
> > Hi Geert,
> >
> > Thank you!
>
> We should probably pick this one over Sudip's duplicate?
>
> Cheers,
>
> Moritz
>
Yes, Geert originally submitted 11/9/2015.
Alan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA
2016-06-05 9:39 [PATCH v2] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA Geert Uytterhoeven
2016-06-06 18:02 ` atull
@ 2016-06-07 14:17 ` atull
1 sibling, 0 replies; 5+ messages in thread
From: atull @ 2016-06-07 14:17 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Greg Kroah-Hartman, Moritz Fischer, linux-kernel
On Sun, 5 Jun 2016, Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> ERROR: "bad_dma_ops" [drivers/fpga/zynq-fpga.ko] undefined!
>
> Add a dependency on HAS_DMA to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Reviewed-by: Moritz Fischer <moritz.fischer@ettus.com>
Acked-by: Alan Tull <atull@opensource.altera.com>
Thanks!
Alan
> ---
> v2:
> - Add Reviewed-by,
> - Updated error message for recent kernels,
> - Submit to Greg, as requested by Alan.
> ---
> drivers/fpga/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index c9b9fdf6cfbbeb6d..d61410299ec0cf80 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA
>
> config FPGA_MGR_ZYNQ_FPGA
> tristate "Xilinx Zynq FPGA"
> + depends on HAS_DMA
> help
> FPGA manager driver support for Xilinx Zynq FPGAs.
>
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-06-07 14:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-05 9:39 [PATCH v2] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA Geert Uytterhoeven
2016-06-06 18:02 ` atull
2016-06-06 20:37 ` Moritz Fischer
2016-06-07 14:11 ` atull
2016-06-07 14:17 ` atull
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox