From: Julia Lawall <julia.lawall@lip6.fr>
To: Namrata A Shettar <namrataashettar@gmail.com>
Cc: outreachy-kernel <outreachy-kernel@googlegroups.com>,
arnd@arndb.de, abbotti@mev.co.uk, hsweeten@visionengravers.com,
gregkh@linuxfoundation.org, badbuddha91@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line
Date: Tue, 13 Sep 2016 11:57:12 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1609131155250.3355@hadrien> (raw)
In-Reply-To: <e2fdc076-900a-4a25-9e5a-49d693bd3c74@googlegroups.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1889 bytes --]
On Tue, 13 Sep 2016, Namrata A Shettar wrote:
> Yes I realize that this may be wrong.Thank you for your inputs!
>
> Also,The version of the kernel I am using is : 4.8.0-rc2+
You should be using what you get by doing the following command:
git clone -b staging-testing git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
Maybe this is what you already have?
julia
>
> Thanks,
> Namrata
>
> On Tuesday, September 13, 2016 at 3:06:06 PM UTC+5:30, Julia Lawall wrote:
>
>
> On Tue, 13 Sep 2016, Arnd Bergmann wrote:
>
> > On Tuesday, September 13, 2016 11:51:53 AM CEST Namrata A
> Shettar wrote:
> > > --- a/drivers/staging/comedi/comedi_pcmcia.c
> > > +++ b/drivers/staging/comedi/comedi_pcmcia.c
> > > @@ -18,7 +18,6 @@
> > >
> > > #include <linux/module.h>
> > > #include <linux/kernel.h>
> > > -
> > > #include "comedi_pcmcia.h"
> > >
> > > /**
> > >
> >
> > I would argue that checkpatch is wrong here, it's very common
> to have
> > an empty line between the global and the local header files.
>
> I forwarded this to Joe Perches, and he pointed out that
> checkpatch
> doesn't give a warning for this. Namrata, what version of the
> kernel are
> you using?
>
> julia
>
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/e2fdc076-900a-4a25-9e5a-
> 49d693bd3c74%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
prev parent reply other threads:[~2016-09-13 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAFrQyDErWX1NgsruZtt10hihZR2J3cvK-Q9Zj_dp_GLc_0mLmA@mail.gmail.com>
2016-09-13 7:27 ` [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line Julia Lawall
2016-09-13 7:33 ` Arnd Bergmann
2016-09-13 9:36 ` Julia Lawall
[not found] ` <e2fdc076-900a-4a25-9e5a-49d693bd3c74@googlegroups.com>
2016-09-13 9:57 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1609131155250.3355@hadrien \
--to=julia.lawall@lip6.fr \
--cc=abbotti@mev.co.uk \
--cc=arnd@arndb.de \
--cc=badbuddha91@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namrataashettar@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox