From: Julia Lawall <julia.lawall@lip6.fr>
To: Sandhya Bankar <bankarsandhya512@gmail.com>
Cc: outreachy-kernel@googlegroups.com, sudipm.mukherjee@gmail.com,
teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] [PATCH] Staging: sm750fb: Use x instead of x != NULL
Date: Wed, 14 Sep 2016 14:35:41 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1609141435030.3092@hadrien> (raw)
In-Reply-To: <20160914123349.GA3770@sandhya>
On Wed, 14 Sep 2016, Sandhya Bankar wrote:
> Use x instead of x != NULL .
> This patch removes the explicit NULL comparisons.This issue is found by checkpatch.pl script .
> CHECK: Comparison to NULL could be written "pCurrentDviCtrl->pfnInit"
OK for the patch, but please put a space after the end of each sentence,
and don't allow the lines in your commit message to go over 80 characters.
julia
>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
> index a4a2550..8a39e0e 100644
> --- a/drivers/staging/sm750fb/ddk750_dvi.c
> +++ b/drivers/staging/sm750fb/ddk750_dvi.c
> @@ -45,7 +45,7 @@ int dviInit(
> dvi_ctrl_device_t *pCurrentDviCtrl;
>
> pCurrentDviCtrl = g_dcftSupportedDviController;
> - if (pCurrentDviCtrl->pfnInit != NULL) {
> + if (pCurrentDviCtrl->pfnInit) {
> return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect, dualEdgeClkSelect, hsyncEnable,
> vsyncEnable, deskewEnable, deskewSetting, continuousSyncEnable,
> pllFilterEnable, pllFilterValue);
> --
> 1.8.2.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914123349.GA3770%40sandhya.
> For more options, visit https://groups.google.com/d/optout.
>
prev parent reply other threads:[~2016-09-14 12:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 12:33 [PATCH] Staging: sm750fb: Use x instead of x != NULL Sandhya Bankar
2016-09-14 12:35 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1609141435030.3092@hadrien \
--to=julia.lawall@lip6.fr \
--cc=bankarsandhya512@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox