From: Thomas Gleixner <tglx@linutronix.de>
To: Ruslan Ruslichenko <rruslich@cisco.com>
Cc: Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
xe-linux-external@cisco.com
Subject: Re: [PATCH] x86/ioapic: add IO-APIC irq_chip retrigger hook
Date: Wed, 18 Jan 2017 11:46:46 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1701181144270.3464@nanos> (raw)
In-Reply-To: <1484662432-13580-1-git-send-email-rruslich@cisco.com>
On Tue, 17 Jan 2017, Ruslan Ruslichenko wrote:
> After commit d32932d02e18 ("x86/irq: Convert IOAPIC to use hierarchical
> irqdomain interfaces") IO-APIC is switched to hierarchical irqdomain
> implementation. Also this patch removed irq_retrigger hook for IO-APIC
> chip which seem to be wrong. Without this hook some edge-triggered irq's
> might be lost, since kernel uses it to retrigger edge irq's triggered
> while they are being handled or disabled by driver
Restoring the callbacks is the right thing to do, but there is no problem
because if the retrigger callback is empty then pending edge interrupts are
resent by software. It's just less efficient, but not a issue.
Thanks,
tglx
next prev parent reply other threads:[~2017-01-18 10:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 14:13 [PATCH] x86/ioapic: add IO-APIC irq_chip retrigger hook Ruslan Ruslichenko
2017-01-18 10:46 ` Thomas Gleixner [this message]
2017-01-18 14:26 ` Ruslan Ruslichenko -X (rruslich - GLOBALLOGIC INC at Cisco)
2017-01-18 14:36 ` Thomas Gleixner
2017-01-18 10:55 ` [tip:x86/apic] x86/ioapic: Restore IO-APIC irq_chip retrigger callback tip-bot for Ruslan Ruslichenko
2017-01-18 14:42 ` [tip:x86/urgent] " tip-bot for Ruslan Ruslichenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1701181144270.3464@nanos \
--to=tglx@linutronix.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rruslich@cisco.com \
--cc=x86@kernel.org \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox