The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: simran singhal <singhalsimran0@gmail.com>
Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
	gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, oleg.drokin@intel.com,
	marvin24@gmx.de, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 5/5] staging: rtl8712: Remove unnecessary cast on void pointer
Date: Thu, 2 Mar 2017 22:56:00 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1703022254450.2175@hadrien> (raw)
In-Reply-To: <1488489544-25941-5-git-send-email-singhalsimran0@gmail.com>

> @@ -635,7 +635,7 @@ void r8712_reordering_ctrl_timeout_handler(void *pcontext)
>  {
>  	unsigned long irql;
>  	struct recv_reorder_ctrl *preorder_ctrl =
> -				 (struct recv_reorder_ctrl *)pcontext;
> +				 pcontext;

Coccinelle doesn't always generate code in the best way.  pcontext can be
moved up to the previous line in this case.

julia

  reply	other threads:[~2017-03-02 22:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-02 21:19 [PATCH 1/5] staging: nvec: Remove unnecessary cast on void pointer simran singhal
2017-03-02 21:19 ` [PATCH 2/5] staging: lustre: " simran singhal
2017-03-02 21:19 ` [PATCH 3/5] staging: lustre: " simran singhal
2017-03-02 21:43   ` Joe Perches
2017-03-02 21:55     ` SIMRAN SINGHAL
2017-03-02 21:59       ` Joe Perches
2017-03-02 22:05         ` SIMRAN SINGHAL
2017-03-02 22:07           ` [Outreachy kernel] " Julia Lawall
2017-03-02 22:09           ` Joe Perches
2017-03-03 22:41   ` kbuild test robot
2017-03-04  0:16   ` kbuild test robot
2017-03-02 21:19 ` [PATCH 4/5] staging: rts5208: " simran singhal
2017-03-02 21:56   ` [Outreachy kernel] " Julia Lawall
2017-03-02 21:58     ` SIMRAN SINGHAL
2017-03-02 21:19 ` [PATCH 5/5] staging: rtl8712: " simran singhal
2017-03-02 21:56   ` Julia Lawall [this message]
2017-03-02 21:57     ` [Outreachy kernel] " SIMRAN SINGHAL

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1703022254450.2175@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=Larry.Finger@lwfinger.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=florian.c.schilhabel@googlemail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marvin24@gmx.de \
    --cc=oleg.drokin@intel.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=singhalsimran0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox