From: Julia Lawall <julia.lawall@inria.fr>
To: Denis Efremov <efremov@linux.com>
Cc: Markus Elfring <Markus.Elfring@web.de>,
Coccinelle <cocci@systeme.lip6.fr>,
linux-kernel@vger.kernel.org
Subject: Re: [v2 1/4] coccinelle: api: extend memdup_user transformation with GFP_USER
Date: Sat, 18 Jul 2020 15:29:58 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2007181529460.2538@hadrien> (raw)
In-Reply-To: <cf2bd604-3094-f90a-52a8-ff5a44cf3850@linux.com>
On Sat, 18 Jul 2020, Denis Efremov wrote:
> Hi,
>
> On 7/18/20 9:45 AM, Julia Lawall wrote:
> > This on is indeed a problem. I think it was not detected in testing,
> > because in the current kernel the rule never applies. But Denis, in
> >
> > - to = \(kmalloc\|kzalloc\)
> > (size,\(GFP_KERNEL\|GFP_USER\|
> > \(GFP_KERNEL\|GFP_USER\)|__GFP_NOWARN\));
> >
> > you do indeed need to put - in front of the second and third lines as
> > well.
>
> Thanks, Markus, Julia. I will send v3. Julia, is it ok with you, if I will
> drop the last patch with "selfcheck" this time?
That would be perfect, thanks.
julia
next prev parent reply other threads:[~2020-07-18 13:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-18 5:56 [v2 1/4] coccinelle: api: extend memdup_user transformation with GFP_USER Markus Elfring
2020-07-18 6:45 ` Julia Lawall
2020-07-18 7:09 ` Markus Elfring
2020-07-18 8:41 ` Julia Lawall
2020-07-18 9:16 ` Markus Elfring
2020-07-18 12:14 ` Markus Elfring
2020-07-18 13:11 ` Denis Efremov
2020-07-18 13:29 ` Julia Lawall [this message]
2020-07-19 8:36 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2007181529460.2538@hadrien \
--to=julia.lawall@inria.fr \
--cc=Markus.Elfring@web.de \
--cc=cocci@systeme.lip6.fr \
--cc=efremov@linux.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox