From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@inria.fr>,
Denis Efremov <efremov@linux.com>,
Coccinelle <cocci@systeme.lip6.fr>
Cc: Gilles Muller <Gilles.Muller@lip6.fr>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [v2 1/4] coccinelle: api: extend memdup_user transformation with GFP_USER
Date: Sat, 18 Jul 2020 09:09:10 +0200 [thread overview]
Message-ID: <fa0ec546-9aee-5c95-428c-a225a3521f6f@web.de> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2007180841520.2538@hadrien>
>>> Applied.
>>
>> Do you care for patch review concerns according to this SmPL script adjustment?
>>
>> * https://lore.kernel.org/cocci/5c0dae88-e172-3ba6-f86c-d1a6238bb4c4@web.de/
>> https://lkml.org/lkml/2020/6/9/568
>
> This one it complete nonsense.
I hope that different views can be clarified for such a software situation
in more constructive ways.
>> * https://lore.kernel.org/cocci/c3464cad-e567-9ef5-b4e3-a01e3b11120b@web.de/
>> https://lkml.org/lkml/2020/6/8/637
>
> This on is indeed a problem.
I find this feedback interesting.
* How does it fit to your response “Applied”?
* Will it trigger any more consequences?
> Markus, if you would limit your comments to suggesting SmPL code
> that is actually correct, ie that you have tested,
Patch reviews contain usual risks that suggestions are presented
which can be still questionable.
> and 2) stop suggesting stupid things over and over
We come along different development views.
> like that putting all of the virtual declarations on
> the same line would save space (it does, but who cares),
It seems that you admit a possibly desirable effect.
Will any more developers care also for SmPL coding style aspects?
> then I would take your suggestions more seriously.
Your change acceptance is varying to your development mood
(and other factors), isn't it?
Regards,
Markus
next prev parent reply other threads:[~2020-07-18 7:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-18 5:56 [v2 1/4] coccinelle: api: extend memdup_user transformation with GFP_USER Markus Elfring
2020-07-18 6:45 ` Julia Lawall
2020-07-18 7:09 ` Markus Elfring [this message]
2020-07-18 8:41 ` Julia Lawall
2020-07-18 9:16 ` Markus Elfring
2020-07-18 12:14 ` Markus Elfring
2020-07-18 13:11 ` Denis Efremov
2020-07-18 13:29 ` Julia Lawall
2020-07-19 8:36 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa0ec546-9aee-5c95-428c-a225a3521f6f@web.de \
--to=markus.elfring@web.de \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=efremov@linux.com \
--cc=julia.lawall@inria.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox