public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Vegard Nossum <vegard.nossum@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-acpi@vger.kernel.org, Zhao Yakui <yakui.zhao@intel.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Alexey Starikovskiy <astarikovskiy@suse.de>,
	Yinghai Lu <yhlu.kernel@gmail.com>
Subject: [PATCH] ACPI: add standard linux WARN() output to ACPI warnings
Date: Tue, 24 Jun 2008 22:34:25 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.1.10.0806242231120.3014@localhost.localdomain> (raw)
In-Reply-To: <20080620142224.GF8135@elte.hu>

From: Len Brown <len.brown@intel.com>

Signed-off-by: Len Brown <len.brown@intel.com>
---
> i have hit this warning for the first time in January 2008:
...
> that's why WARN_ON()s are so important - there's no way my automated 
> tools (or even i, when taking a casual look at the logs) could have 
> picked up that new ACPI Exception - if each subsystem has different 
> warnings (which change frequently) then it's sheer impossible to 
> automate the answer to the "does that log show any anomaly" question. 

Maybe something like this would help?
(totally untested)

-Len

diff --git a/drivers/acpi/utilities/utmisc.c b/drivers/acpi/utilities/utmisc.c
index 1f057b7..d53e82c 100644
--- a/drivers/acpi/utilities/utmisc.c
+++ b/drivers/acpi/utilities/utmisc.c
@@ -1028,6 +1028,7 @@ acpi_ut_error(char *module_name, u32 line_number, char *format, ...)
 {
 	va_list args;
 
+	warn_on_slowpath(module_name, line_number);
 	acpi_os_printf("ACPI Error (%s-%04d): ", module_name, line_number);
 
 	va_start(args, format);
@@ -1042,6 +1043,7 @@ acpi_ut_exception(char *module_name,
 {
 	va_list args;
 
+	warn_on_slowpath(module_name, line_number);
 	acpi_os_printf("ACPI Exception (%s-%04d): %s, ", module_name,
 		       line_number, acpi_format_exception(status));
 
@@ -1058,6 +1060,7 @@ acpi_ut_warning(char *module_name, u32 line_number, char *format, ...)
 {
 	va_list args;
 
+	warn_on_slowpath(module_name, line_number);
 	acpi_os_printf("ACPI Warning (%s-%04d): ", module_name, line_number);
 
 	va_start(args, format);

  reply	other threads:[~2008-06-25  2:35 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-20  9:52 [bug, acpi] BUG: spinlock bad magic on CPU#0, swapper/1, ACPI Exception (utmutex-0263): AE_BAD_PARAMETER Ingo Molnar
2008-06-20 13:11 ` Vegard Nossum
2008-06-20 13:56 ` [PATCH] ACPI: don't walk tables if ACPI was disabled Vegard Nossum
2008-06-20 14:22   ` Ingo Molnar
2008-06-25  2:34     ` Len Brown [this message]
2008-06-25  2:49       ` [PATCH] ACPI: add standard linux WARN() output to ACPI warnings Arjan van de Ven
2008-06-25  3:10         ` Len Brown
2008-06-26  3:57           ` Len Brown
2008-06-20 19:00   ` [PATCH] ACPI: don't walk tables if ACPI was disabled Len Brown
2008-06-20 20:40     ` Vegard Nossum
2008-06-20 21:27       ` Vegard Nossum
2008-06-21  8:19         ` Vegard Nossum
2008-06-24 11:41           ` Ingo Molnar
2008-06-24 11:52             ` Vegard Nossum
2008-06-24 15:22               ` Bjorn Helgaas
2008-06-25  1:37               ` Zhao Yakui
2008-06-25 15:08                 ` Bjorn Helgaas
2008-06-26  3:02                   ` Zhao Yakui
2008-06-26 16:44                     ` Bjorn Helgaas
2008-06-25  2:41             ` Len Brown
2008-06-25  7:07               ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.10.0806242231120.3014@localhost.localdomain \
    --to=lenb@kernel.org \
    --cc=astarikovskiy@suse.de \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rjw@sisk.pl \
    --cc=vegard.nossum@gmail.com \
    --cc=yakui.zhao@intel.com \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox